Re: [PATCH net-next 03/19] net: usb: aqc111: Add implementation of read and write commands

From: David Miller <davem@davemloft.net>
Date: 2018-10-05 17:40:55
Also in: linux-usb

From: Igor Russkikh <redacted>
Date: Fri, 5 Oct 2018 10:24:44 +0000
+static int __aqc111_read_cmd(struct usbnet *dev, u8 cmd, u16 value,
+			     u16 index, u16 size, void *data, int nopm)
+{
+	int ret;
+	int (*fn)(struct usbnet *dev, u8 cmd, u8 reqtype, u16 value,
+		  u16 index, void *data, u16 size);
Again, please order local variables from longest to shortest line.

I won't explicitly point out the others, you need to audit your entire
submission for this problem and fix it up.

Thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help