Re: [PATCH net-next 17/19] net: usb: aqc111: Initialize ethtool_ops structure
From: Andrew Lunn <andrew@lunn.ch>
Date: 2018-10-06 17:08:46
Also in:
linux-usb
On Fri, Oct 05, 2018 at 10:25:22AM +0000, Igor Russkikh wrote:
quoted hunk
From: Dmitry Bezrukov <redacted> Implement get_drvinfo, set/get_msglevel, get_link callbacks Signed-off-by: Dmitry Bezrukov <redacted> Signed-off-by: Igor Russkikh <redacted> --- drivers/net/usb/aqc111.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)diff --git a/drivers/net/usb/aqc111.c b/drivers/net/usb/aqc111.c index 9908b0a04da6..ade2b60b4811 100644 --- a/drivers/net/usb/aqc111.c +++ b/drivers/net/usb/aqc111.c@@ -9,6 +9,7 @@ #include <linux/module.h> #include <linux/netdevice.h> +#include <linux/ethtool.h> #include <linux/mii.h> #include <linux/usb.h> #include <linux/crc32.h>@@ -18,6 +19,9 @@ #include "aqc111.h" +#define DRIVER_VERSION "1.0.0.0"
Hi Igor This is been discussed a number of times before, and i expect it to be discussed again. Driver versions of useless. Please drop it.
+#define DRIVER_NAME "Aquantia AQtion USB to 5GbE"
It might be nice to include the module name in here, making it easy to link the module to the driver.
quoted hunk
+ static int __aqc111_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index, u16 size, void *data, int nopm) {@@ -170,6 +174,24 @@ static int aq_mdio_write_cmd(struct usbnet *dev, u16 value, u16 index, return aqc111_write_cmd(dev, AQ_PHY_CMD, value, index, size, data); }
Andrew