Re: [PATCH net-next 01/19] net: usb: aqc111: Driver skeleton for Aquantia AQtion USB to 5GbE
From: Bjørn Mork <bjorn@mork.no>
Date: 2018-10-09 13:37:47
Also in:
linux-usb
Igor Russkikh [off-list ref] writes:
quoted
+static const struct driver_info aqc111_info = {+ .description = "Aquantia AQtion USB to 5GbE Controller", +}; + +#define AQC111_USB_ETH_DEV(vid, pid, table) \ + .match_flags = USB_DEVICE_ID_MATCH_DEVICE | \ + USB_DEVICE_ID_MATCH_INT_CLASS, \ + USB_DEVICE(vid, pid), \ + .bInterfaceClass = USB_CLASS_VENDOR_SPEC, \ + .driver_info = (unsigned long)&table, \ +}, \ +{ \ + .match_flags = USB_DEVICE_ID_MATCH_DEVICE | \ + USB_DEVICE_ID_MATCH_INT_INFO, \ + USB_DEVICE(vid, pid), \ + .bInterfaceClass = USB_CLASS_COMM, \ + .bInterfaceSubClass = USB_CDC_SUBCLASS_ETHERNET, \ + .bInterfaceProtocol = USB_CDC_PROTO_NONE +
Is the missing .driver_info for the CDC class intentional? If so, then why include it at all? Bjørn