[PATCH] ipw2x00: clean up clang warning on extraneous parentheses

Subsystems: intel pro/wireless 2100, 2200bg, 2915abg network connection support, the rest

STALE2900d

3 messages, 3 authors, 2018-10-01 · open the first message on its own page

[PATCH] ipw2x00: clean up clang warning on extraneous parentheses

From: Colin King <hidden>
Date: 2018-09-30 22:38:16

From: Colin Ian King <redacted>

There are extraneous parantheses that are causing clang to produce a
warning so remove these.

Clean up clang warning:
equality comparison with extraneous parentheses [-Wparentheses-equality]

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
index 9644e7b93645..bbdca13c5a9f 100644
--- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c
@@ -5652,7 +5652,7 @@ static void ipw_merge_adhoc_network(struct work_struct *work)
 		}
 
 		mutex_lock(&priv->mutex);
-		if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) {
+		if (priv->ieee->iw_mode == IW_MODE_ADHOC) {
 			IPW_DEBUG_MERGE("remove network %*pE\n",
 					priv->essid_len, priv->essid);
 			ipw_remove_current_network(priv);
-- 
2.17.1

Re: [PATCH] ipw2x00: clean up clang warning on extraneous parentheses

From: Sergei Shtylyov <hidden>
Date: 2018-10-01 08:14:55

Hello!

On 10/1/2018 1:38 AM, Colin King wrote:
From: Colin Ian King <redacted>

There are extraneous parantheses that are causing clang to produce a
    Parentheses.
warning so remove these.

Clean up clang warning:
equality comparison with extraneous parentheses [-Wparentheses-equality]

Signed-off-by: Colin Ian King <redacted>
[...]

MBR, Sergei

Re: [PATCH] ipw2x00: clean up clang warning on extraneous parentheses

From: Kalle Valo <hidden>
Date: 2018-10-01 15:49:07

Colin King [off-list ref] wrote:
From: Colin Ian King <redacted>

There are extraneous parantheses that are causing clang to produce a
warning so remove these.

Clean up clang warning:
equality comparison with extraneous parentheses [-Wparentheses-equality]

Signed-off-by: Colin Ian King <redacted>
I applied an identical patch few minutes ago:

c15ace868dd1 ipw2x00: Remove unnecessary parentheses

Patch set to Rejected.

-- 
https://patchwork.kernel.org/patch/10621549/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help