[PATCH] net: phy: Fix a unused function gcc warning.

Fix the following compile warning:

drivers/net/phy/mdio-bcm-unimac.c:321:12: warning: 'unimac_mdio_suspend' defined but not used [-Wunused-function]
 static int unimac_mdio_suspend(struct device *d)
            ^
drivers/net/phy/mdio-bcm-unimac.c:330:12: warning: 'unimac_mdio_resume' defined but not used [-Wunused-function]
 static int unimac_mdio_resume(struct device *d)

Signed-off-by: zhong jiang <redacted>
---
 drivers/net/phy/mdio-bcm-unimac.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/phy/mdio-bcm-unimac.c b/drivers/net/phy/mdio-bcm-unimac.c
index 80b9583..f5b83ea 100644
--- a/drivers/net/phy/mdio-bcm-unimac.c
+++ b/drivers/net/phy/mdio-bcm-unimac.c

@@ -318,6 +318,7 @@ static int unimac_mdio_remove(struct platform_device *pdev)
 	return 0;
 }
 
+#ifdef CONFIG_PM_SLEEP
 static int unimac_mdio_suspend(struct device *d)
 {
 	struct unimac_mdio_priv *priv = dev_get_drvdata(d);

@@ -343,6 +344,7 @@ static int unimac_mdio_resume(struct device *d)
 
 static SIMPLE_DEV_PM_OPS(unimac_mdio_pm_ops,
 			 unimac_mdio_suspend, unimac_mdio_resume);
+#endif /* CONFIG_PM_SLEEP */
 
 static const struct of_device_id unimac_mdio_ids[] = {
 	{ .compatible = "brcm,genet-mdio-v5", },

@@ -359,7 +361,9 @@ static SIMPLE_DEV_PM_OPS(unimac_mdio_pm_ops,
 	.driver = {
 		.name = UNIMAC_MDIO_DRV_NAME,
 		.of_match_table = unimac_mdio_ids,
+#ifdef CONFIG_PM_SLEEP
 		.pm = &unimac_mdio_pm_ops,
+#endif
 	},
 	.probe	= unimac_mdio_probe,
 	.remove	= unimac_mdio_remove,

-- 
1.7.12.4

On September 28, 2018 10:11:43 PM PDT, zhong jiang [off-list ref] wrote:

Fix the following compile warning:

drivers/net/phy/mdio-bcm-unimac.c:321:12: warning:
'unimac_mdio_suspend' defined but not used [-Wunused-function]
static int unimac_mdio_suspend(struct device *d)
           ^
drivers/net/phy/mdio-bcm-unimac.c:330:12: warning: 'unimac_mdio_resume'
defined but not used [-Wunused-function]
static int unimac_mdio_resume(struct device *d)

Signed-off-by: zhong jiang <redacted>

Thank you, Arnd already sent a patch for this which got accepted:

https://patchwork.ozlabs.org/patch/975088/
-- 
Florian

On 2018/9/30 4:36, Florian Fainelli wrote:

On September 28, 2018 10:11:43 PM PDT, zhong jiang [off-list ref] wrote:

quoted

Fix the following compile warning:

drivers/net/phy/mdio-bcm-unimac.c:321:12: warning:
'unimac_mdio_suspend' defined but not used [-Wunused-function]
static int unimac_mdio_suspend(struct device *d)
           ^
drivers/net/phy/mdio-bcm-unimac.c:330:12: warning: 'unimac_mdio_resume'
defined but not used [-Wunused-function]
static int unimac_mdio_resume(struct device *d)

Signed-off-by: zhong jiang <redacted>

Thank you, Arnd already sent a patch for this which got accepted:

https://patchwork.ozlabs.org/patch/975088/

Ok, Thanks, I miss that.

Sincerely,
zhong jiang