[PATCH net-next] net: dsa: b53: Don't assign autonegotiation enabled
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2018-09-21 22:30:12
Also in:
lkml
Subsystem:
broadcom b53/sf2 ethernet switch driver, networking drivers, networking [dsa], the rest · Maintainers:
Florian Fainelli, Jonas Gorski, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andrew Lunn, Vladimir Oltean, Linus Torvalds
PHYLINK takes care of filing the right information into
state->an_enabled, get rid of the read from the SerDes's BMCR register.
Fixes: 0e01491de646 ("net: dsa: b53: Add SerDes support")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/dsa/b53/b53_serdes.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/dsa/b53/b53_serdes.c b/drivers/net/dsa/b53/b53_serdes.c
index b45c55e0b8b4..629bf14128a2 100644
--- a/drivers/net/dsa/b53/b53_serdes.c
+++ b/drivers/net/dsa/b53/b53_serdes.c@@ -100,15 +100,13 @@ int b53_serdes_link_state(struct b53_device *dev, int port, struct phylink_link_state *state) { u8 lane = b53_serdes_map_lane(dev, port); - u16 dig, bmcr, bmsr; + u16 dig, bmsr; if (lane == B53_INVALID_LANE) return 1; dig = b53_serdes_read(dev, lane, B53_SERDES_DIGITAL_STATUS, SERDES_DIGITAL_BLK); - bmcr = b53_serdes_read(dev, lane, B53_SERDES_MII_REG(MII_BMCR), - SERDES_MII_BLK); bmsr = b53_serdes_read(dev, lane, B53_SERDES_MII_REG(MII_BMSR), SERDES_MII_BLK);
@@ -129,7 +127,6 @@ int b53_serdes_link_state(struct b53_device *dev, int port, } state->duplex = dig & DUPLEX_STATUS ? DUPLEX_FULL : DUPLEX_HALF; - state->an_enabled = !!(bmcr & BMCR_ANENABLE); state->an_complete = !!(bmsr & BMSR_ANEGCOMPLETE); state->link = !!(dig & LINK_STATUS); if (dig & PAUSE_RESOLUTION_RX_SIDE)
--
2.17.1