[PATCH] net: toshiba: remove a redundant local variable 'index_specified'

Subsystems: networking drivers, ps3 platform support, the rest

STALE2912d

4 messages, 3 authors, 2018-09-20 · open the first message on its own page

[PATCH] net: toshiba: remove a redundant local variable 'index_specified'

From: zhong jiang <hidden>
Date: 2018-09-20 02:09:58

The local variable 'index_specified' is never used after being assigned.
hence it should be redundant adn can be removed.

Signed-off-by: zhong jiang <redacted>
---
 drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
index 302079e..00ab417 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
@@ -1094,7 +1094,7 @@ static int gelic_wl_get_encode(struct net_device *netdev,
 	struct gelic_wl_info *wl = port_wl(netdev_priv(netdev));
 	struct iw_point *enc = &data->encoding;
 	unsigned long irqflag;
-	unsigned int key_index, index_specified;
+	unsigned int key_index;
 	int ret = 0;
 
 	pr_debug("%s: <-\n", __func__);
@@ -1105,13 +1105,10 @@ static int gelic_wl_get_encode(struct net_device *netdev,
 		return -EINVAL;
 
 	spin_lock_irqsave(&wl->lock, irqflag);
-	if (key_index) {
-		index_specified = 1;
+	if (key_index)
 		key_index--;
-	} else {
-		index_specified = 0;
+	else
 		key_index = wl->current_key;
-	}
 
 	if (wl->group_cipher_method == GELIC_WL_CIPHER_WEP) {
 		switch (wl->auth_method) {
-- 
1.7.12.4

Re: [PATCH] net: toshiba: remove a redundant local variable 'index_specified'

From: David Miller <davem@davemloft.net>
Date: 2018-09-20 06:09:04

From: zhong jiang <redacted>
Date: Thu, 20 Sep 2018 09:56:05 +0800
The local variable 'index_specified' is never used after being assigned.
hence it should be redundant adn can be removed.

Signed-off-by: zhong jiang <redacted>
Applied.

Re: [PATCH] net: toshiba: remove a redundant local variable 'index_specified'

From: Sergei Shtylyov <hidden>
Date: 2018-09-20 10:23:39

On 9/20/2018 4:56 AM, zhong jiang wrote:
The local variable 'index_specified' is never used after being assigned.
hence it should be redundant adn can be removed.
    s/adn/and/.
Signed-off-by: zhong jiang <redacted>
[...]

MBR, Sergei

Re: [PATCH] net: toshiba: remove a redundant local variable 'index_specified'

From: zhong jiang <hidden>
Date: 2018-09-20 11:35:00

On 2018/9/20 18:23, Sergei Shtylyov wrote:
On 9/20/2018 4:56 AM, zhong jiang wrote:
quoted
The local variable 'index_specified' is never used after being assigned.
hence it should be redundant adn can be removed.
   s/adn/and/.
Spelling mistake.  Thanks, checkpatch.pl can not find this. :-[ . I will be appreaciated
that David help me correct that.

Sincerely,
zhong jiang
quoted
Signed-off-by: zhong jiang <redacted>
[...]

MBR, Sergei

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help