[PATCH] net: ibm: remove redundant local variables 'act_nr_of_entries' and 'act_pages'

Subsystems: networking drivers, the rest

STALE2915d

2 messages, 2 authors, 2018-09-20 · open the first message on its own page

[PATCH] net: ibm: remove redundant local variables 'act_nr_of_entries' and 'act_pages'

From: zhong jiang <hidden>
Date: 2018-09-19 14:43:19

That local variable are never used after being assigned.
hence it should be redundant and can be removed.

Signed-off-by: zhong jiang <redacted>
---
 drivers/net/ethernet/ibm/ehea/ehea_qmr.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ehea/ehea_qmr.c b/drivers/net/ethernet/ibm/ehea/ehea_qmr.c
index a0820f7..5e4e371 100644
--- a/drivers/net/ethernet/ibm/ehea/ehea_qmr.c
+++ b/drivers/net/ethernet/ibm/ehea/ehea_qmr.c
@@ -125,7 +125,7 @@ struct ehea_cq *ehea_create_cq(struct ehea_adapter *adapter,
 	struct ehea_cq *cq;
 	struct h_epa epa;
 	u64 *cq_handle_ref, hret, rpage;
-	u32 act_nr_of_entries, act_pages, counter;
+	u32 counter;
 	int ret;
 	void *vpage;
 
@@ -140,8 +140,6 @@ struct ehea_cq *ehea_create_cq(struct ehea_adapter *adapter,
 	cq->adapter = adapter;
 
 	cq_handle_ref = &cq->fw_handle;
-	act_nr_of_entries = 0;
-	act_pages = 0;
 
 	hret = ehea_h_alloc_resource_cq(adapter->handle, &cq->attr,
 					&cq->fw_handle, &cq->epas);
-- 
1.7.12.4

Re: [PATCH] net: ibm: remove redundant local variables 'act_nr_of_entries' and 'act_pages'

From: David Miller <davem@davemloft.net>
Date: 2018-09-20 04:26:59

From: zhong jiang <redacted>
Date: Wed, 19 Sep 2018 22:30:49 +0800
That local variable are never used after being assigned.
hence it should be redundant and can be removed.

Signed-off-by: zhong jiang <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help