[PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive

Subsystems: broadcom brcm80211 ieee802.11 wireless drivers, the rest

STALE2911d

2 messages, 2 authors, 2018-09-20 · open the first message on its own page

[PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive

From: zhong jiang <hidden>
Date: 2018-09-12 14:22:33

debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
remove the condition check before debugfs_remove_recursive.

Signed-off-by: zhong jiang <redacted>
---
 drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c
index 2fe1f68..3bd54f1 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c
@@ -62,8 +62,7 @@ int brcms_debugfs_attach(struct brcms_pub *drvr)
 
 void brcms_debugfs_detach(struct brcms_pub *drvr)
 {
-	if (!IS_ERR_OR_NULL(drvr->dbgfs_dir))
-		debugfs_remove_recursive(drvr->dbgfs_dir);
+	debugfs_remove_recursive(drvr->dbgfs_dir);
 }
 
 struct dentry *brcms_debugfs_get_devdir(struct brcms_pub *drvr)
-- 
1.7.12.4

Re: [PATCH] brcm80211: remove redundant condition check before debugfs_remove_recursive

From: Kalle Valo <hidden>
Date: 2018-09-20 12:07:12

zhong jiang [off-list ref] wrote:
debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
remove the condition check before debugfs_remove_recursive.

Signed-off-by: zhong jiang <redacted>
It seems you already submitted an identical patch four days earlier:

https://patchwork.kernel.org/patch/10593061/

Why the duplicate? Please ALWAYS add a changelog and increase the version number:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing

-- 
https://patchwork.kernel.org/patch/10597627/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help