[PATCH net-next] failover: Fix error return code in net_failover_create

Subsystems: networking drivers, net_failover module, the rest

STALE2905d

2 messages, 2 authors, 2018-09-08 · open the first message on its own page

[PATCH net-next] failover: Fix error return code in net_failover_create

From: YueHaibing <hidden>
Date: 2018-09-06 13:04:37

if failover_register failed, 'err' code should be set correctly

Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")
Signed-off-by: YueHaibing <redacted>
---
 drivers/net/net_failover.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c
index 192ae1c..cbcb9f2 100644
--- a/drivers/net/net_failover.c
+++ b/drivers/net/net_failover.c
@@ -761,8 +761,10 @@ struct failover *net_failover_create(struct net_device *standby_dev)
 	netif_carrier_off(failover_dev);
 
 	failover = failover_register(failover_dev, &net_failover_ops);
-	if (IS_ERR(failover))
+	if (IS_ERR(failover)) {
+		err = PTR_ERR(failover);
 		goto err_failover_register;
+	}
 
 	return failover;
 
-- 
2.7.0

Re: [PATCH net-next] failover: Fix error return code in net_failover_create

From: David Miller <davem@davemloft.net>
Date: 2018-09-08 17:31:27

From: YueHaibing <redacted>
Date: Thu, 6 Sep 2018 21:04:12 +0800
if failover_register failed, 'err' code should be set correctly

Fixes: cfc80d9a1163 ("net: Introduce net_failover driver")
Signed-off-by: YueHaibing <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help