[PATCH net-next] net: usbnet: mark expected switch fall-through

Subsystems: networking drivers, the rest, usb "usbnet" driver framework, usb networking drivers

STALE2926d

2 messages, 2 authors, 2018-09-04 · open the first message on its own page

[PATCH net-next] net: usbnet: mark expected switch fall-through

From: Gustavo A. R. Silva <hidden>
Date: 2018-09-03 18:49:17

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1077614 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <redacted>
---
 drivers/net/usb/usbnet.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 770aa62..73aa333 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1527,6 +1527,7 @@ static void usbnet_bh (struct timer_list *t)
 			continue;
 		case tx_done:
 			kfree(entry->urb->sg);
+			/* fall through */
 		case rx_cleanup:
 			usb_free_urb (entry->urb);
 			dev_kfree_skb (skb);
-- 
2.7.4

Re: [PATCH net-next] net: usbnet: mark expected switch fall-through

From: David Miller <davem@davemloft.net>
Date: 2018-09-04 19:20:19

From: "Gustavo A. R. Silva" <redacted>
Date: Mon, 3 Sep 2018 13:48:45 -0500
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 1077614 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help