[PATCH net-next] net: dsa: b53: Uninitialized variable in b53_adjust_link()

Subsystems: broadcom b53/sf2 ethernet switch driver, networking drivers, networking [dsa], the rest

STALE2931d

2 messages, 2 authors, 2018-09-12 · open the first message on its own page

[PATCH net-next] net: dsa: b53: Uninitialized variable in b53_adjust_link()

From: Dan Carpenter <hidden>
Date: 2018-09-08 13:25:17

The "pause" variable is only initialized on BCM5301x.

Fixes: 5e004460f874 ("net: dsa: b53: Add helper to set link parameters")
Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c
index ea4256cd628b..dbf5b86a07fe 100644
--- a/drivers/net/dsa/b53/b53_common.c
+++ b/drivers/net/dsa/b53/b53_common.c
@@ -1025,7 +1025,7 @@ static void b53_adjust_link(struct dsa_switch *ds, int port,
 	struct b53_device *dev = ds->priv;
 	struct ethtool_eee *p = &dev->ports[port].eee;
 	u8 rgmii_ctrl = 0, reg = 0, off;
-	int pause;
+	int pause = 0;
 
 	if (!phy_is_pseudo_fixed_link(phydev))
 		return;

Re: [PATCH net-next] net: dsa: b53: Uninitialized variable in b53_adjust_link()

From: David Miller <davem@davemloft.net>
Date: 2018-09-12 11:03:45

From: Dan Carpenter <redacted>
Date: Sat, 8 Sep 2018 11:39:25 +0300
The "pause" variable is only initialized on BCM5301x.

Fixes: 5e004460f874 ("net: dsa: b53: Add helper to set link parameters")
Signed-off-by: Dan Carpenter <redacted>
Applied, thanks Dan.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help