[PATCH net 1/1] net/smc: no cursor update send in state SMC_INIT

Subsystems: networking [general], shared memory communications (smc) sockets, the rest

STALE2930d

2 messages, 2 authors, 2018-08-04 · open the first message on its own page

[PATCH net 1/1] net/smc: no cursor update send in state SMC_INIT

From: Ursula Braun <hidden>
Date: 2018-08-03 08:39:46

If a writer blocked condition is received without data, the current
consumer cursor is immediately sent. Servers could already receive this
condition in state SMC_INIT without finished tx-setup. This patch
avoids sending a consumer cursor update in this case.

Signed-off-by: Ursula Braun <redacted>
---
 net/smc/smc_cdc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/smc/smc_cdc.c b/net/smc/smc_cdc.c
index a7e8d63fc8ae..9bde1e4ca288 100644
--- a/net/smc/smc_cdc.c
+++ b/net/smc/smc_cdc.c
@@ -233,7 +233,8 @@ static void smc_cdc_msg_recv_action(struct smc_sock *smc,
 			/* force immediate tx of current consumer cursor, but
 			 * under send_lock to guarantee arrival in seqno-order
 			 */
-			smc_tx_sndbuf_nonempty(conn);
+			if (smc->sk.sk_state != SMC_INIT)
+				smc_tx_sndbuf_nonempty(conn);
 		}
 	}
 
-- 
2.16.4

Re: [PATCH net 1/1] net/smc: no cursor update send in state SMC_INIT

From: David Miller <davem@davemloft.net>
Date: 2018-08-04 20:10:35

From: Ursula Braun <redacted>
Date: Fri,  3 Aug 2018 10:38:33 +0200
If a writer blocked condition is received without data, the current
consumer cursor is immediately sent. Servers could already receive this
condition in state SMC_INIT without finished tx-setup. This patch
avoids sending a consumer cursor update in this case.

Signed-off-by: Ursula Braun <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help