[PATCH net-next] tcp: remove unneeded variable 'err'

Subsystems: networking [general], networking [tcp], the rest

STALE2927d

2 messages, 2 authors, 2018-08-03 · open the first message on its own page

[PATCH net-next] tcp: remove unneeded variable 'err'

From: YueHaibing <hidden>
Date: 2018-08-03 08:29:09

variable 'err' is unmodified after initalization,
so simply cleans up it and returns 0.

Signed-off-by: YueHaibing <redacted>
---
 net/ipv4/tcp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 31fa1c0..b8af2fe 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -2531,7 +2531,6 @@ int tcp_disconnect(struct sock *sk, int flags)
 	struct inet_sock *inet = inet_sk(sk);
 	struct inet_connection_sock *icsk = inet_csk(sk);
 	struct tcp_sock *tp = tcp_sk(sk);
-	int err = 0;
 	int old_state = sk->sk_state;
 
 	if (old_state != TCP_CLOSE)
@@ -2612,7 +2611,7 @@ int tcp_disconnect(struct sock *sk, int flags)
 	}
 
 	sk->sk_error_report(sk);
-	return err;
+	return 0;
 }
 EXPORT_SYMBOL(tcp_disconnect);
 
-- 
2.7.0

Re: [PATCH net-next] tcp: remove unneeded variable 'err'

From: David Miller <davem@davemloft.net>
Date: 2018-08-03 23:52:44

From: YueHaibing <redacted>
Date: Fri, 3 Aug 2018 16:28:48 +0800
variable 'err' is unmodified after initalization,
so simply cleans up it and returns 0.

Signed-off-by: YueHaibing <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help