[PATCH net-next] rxrpc: Remove set but not used variable 'nowj'

Subsystems: networking [general], rxrpc sockets (af_rxrpc), the rest

STALE2937d

2 messages, 2 authors, 2018-08-02 · open the first message on its own page

[PATCH net-next] rxrpc: Remove set but not used variable 'nowj'

From: David Howells <dhowells@redhat.com>
Date: 2018-08-02 08:13:39

From: Wei Yongjun <redacted>

Fixes gcc '-Wunused-but-set-variable' warning:

net/rxrpc/proc.c: In function 'rxrpc_call_seq_show':
net/rxrpc/proc.c:66:29: warning:
 variable 'nowj' set but not used [-Wunused-but-set-variable]
  unsigned long timeout = 0, nowj;
                             ^

Signed-off-by: Wei Yongjun <redacted>
Signed-off-by: David Howells <dhowells@redhat.com>
---

 net/rxrpc/proc.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/rxrpc/proc.c b/net/rxrpc/proc.c
index 163d05df339d..9805e3b85c36 100644
--- a/net/rxrpc/proc.c
+++ b/net/rxrpc/proc.c
@@ -63,7 +63,7 @@ static int rxrpc_call_seq_show(struct seq_file *seq, void *v)
 	struct rxrpc_peer *peer;
 	struct rxrpc_call *call;
 	struct rxrpc_net *rxnet = rxrpc_net(seq_file_net(seq));
-	unsigned long timeout = 0, nowj;
+	unsigned long timeout = 0;
 	rxrpc_seq_t tx_hard_ack, rx_hard_ack;
 	char lbuff[50], rbuff[50];
 
@@ -97,7 +97,6 @@ static int rxrpc_call_seq_show(struct seq_file *seq, void *v)
 
 	if (call->state != RXRPC_CALL_SERVER_PREALLOC) {
 		timeout = READ_ONCE(call->expect_rx_by);
-		nowj = jiffies;
 		timeout -= jiffies;
 	}
 

Re: [PATCH net-next] rxrpc: Remove set but not used variable 'nowj'

From: David Miller <davem@davemloft.net>
Date: 2018-08-02 17:21:57

From: David Howells <dhowells@redhat.com>
Date: Thu, 02 Aug 2018 09:13:33 +0100
From: Wei Yongjun <redacted>

Fixes gcc '-Wunused-but-set-variable' warning:

net/rxrpc/proc.c: In function 'rxrpc_call_seq_show':
net/rxrpc/proc.c:66:29: warning:
 variable 'nowj' set but not used [-Wunused-but-set-variable]
  unsigned long timeout = 0, nowj;
                             ^

Signed-off-by: Wei Yongjun <redacted>
Signed-off-by: David Howells <dhowells@redhat.com>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help