[PATCH net-next] rds: remove redundant variable 'rds_ibdev'

Subsystems: networking [general], rds - reliable datagram sockets, the rest

STALE2932d

2 messages, 2 authors, 2018-08-01 · open the first message on its own page

[PATCH net-next] rds: remove redundant variable 'rds_ibdev'

From: YueHaibing <hidden>
Date: 2018-08-01 07:14:27

Variable 'rds_ibdev' is being assigned but never used,
so can be removed.

fix this clang warning:
 net/rds/ib_send.c:762:24: warning: variable ‘rds_ibdev’ set but not used [-Wunused-but-set-variable]

Signed-off-by: YueHaibing <redacted>
---
 net/rds/ib_send.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/net/rds/ib_send.c b/net/rds/ib_send.c
index c4cdfe49..c8dd312 100644
--- a/net/rds/ib_send.c
+++ b/net/rds/ib_send.c
@@ -759,14 +759,11 @@ int rds_ib_xmit_atomic(struct rds_connection *conn, struct rm_atomic_op *op)
 	struct rds_ib_connection *ic = conn->c_transport_data;
 	struct rds_ib_send_work *send = NULL;
 	struct ib_send_wr *failed_wr;
-	struct rds_ib_device *rds_ibdev;
 	u32 pos;
 	u32 work_alloc;
 	int ret;
 	int nr_sig = 0;
 
-	rds_ibdev = ib_get_client_data(ic->i_cm_id->device, &rds_ib_client);
-
 	work_alloc = rds_ib_ring_alloc(&ic->i_send_ring, 1, &pos);
 	if (work_alloc != 1) {
 		rds_ib_stats_inc(s_ib_tx_ring_full);
-- 
2.7.0

Re: [PATCH net-next] rds: remove redundant variable 'rds_ibdev'

From: David Miller <davem@davemloft.net>
Date: 2018-08-01 18:15:24

From: YueHaibing <redacted>
Date: Wed, 1 Aug 2018 15:14:07 +0800
Variable 'rds_ibdev' is being assigned but never used,
so can be removed.

fix this clang warning:
 net/rds/ib_send.c:762:24: warning: variable ‘rds_ibdev’ set but not used [-Wunused-but-set-variable]

Signed-off-by: YueHaibing <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help