[PATCH bpf-next] samples/bpf: xdpsock, minor fixes

Subsystems: bpf [general] (safe dynamic programs and tools), the rest, xdp (express data path)

STALE2899d

3 messages, 3 authors, 2018-08-31 · open the first message on its own page

[PATCH bpf-next] samples/bpf: xdpsock, minor fixes

From: Prashant Bhole <hidden>
Date: 2018-08-31 05:07:53

- xsks_map size was fixed to 4, changed it MAX_SOCKS
- Remove redundant definition of MAX_SOCKS in xdpsock_user.c
- In dump_stats(), add NULL check for xsks[i]

Signed-off-by: Prashant Bhole <redacted>
---
 samples/bpf/xdpsock_kern.c | 2 +-
 samples/bpf/xdpsock_user.c | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/samples/bpf/xdpsock_kern.c b/samples/bpf/xdpsock_kern.c
index d8806c41362e..b8ccd0802b3f 100644
--- a/samples/bpf/xdpsock_kern.c
+++ b/samples/bpf/xdpsock_kern.c
@@ -16,7 +16,7 @@ struct bpf_map_def SEC("maps") xsks_map = {
 	.type = BPF_MAP_TYPE_XSKMAP,
 	.key_size = sizeof(int),
 	.value_size = sizeof(int),
-	.max_entries = 4,
+	.max_entries = MAX_SOCKS,
 };
 
 struct bpf_map_def SEC("maps") rr_map = {
diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c
index b3906111bedb..57ecadc58403 100644
--- a/samples/bpf/xdpsock_user.c
+++ b/samples/bpf/xdpsock_user.c
@@ -118,7 +118,6 @@ struct xdpsock {
 	unsigned long prev_tx_npkts;
 };
 
-#define MAX_SOCKS 4
 static int num_socks;
 struct xdpsock *xsks[MAX_SOCKS];
 
@@ -596,7 +595,7 @@ static void dump_stats(void)
 
 	prev_time = now;
 
-	for (i = 0; i < num_socks; i++) {
+	for (i = 0; i < num_socks && xsks[i]; i++) {
 		char *fmt = "%-15s %'-11.0f %'-11lu\n";
 		double rx_pps, tx_pps;
 
-- 
2.17.1

Re: [PATCH bpf-next] samples/bpf: xdpsock, minor fixes

From: Björn Töpel <hidden>
Date: 2018-08-31 11:38:54

Den fre 31 aug. 2018 kl 03:04 skrev Prashant Bhole
[off-list ref]:
- xsks_map size was fixed to 4, changed it MAX_SOCKS
- Remove redundant definition of MAX_SOCKS in xdpsock_user.c
- In dump_stats(), add NULL check for xsks[i]
Thanks for the cleanup!

Acked-by: Björn Töpel <redacted>
quoted hunk
Signed-off-by: Prashant Bhole <redacted>
---
 samples/bpf/xdpsock_kern.c | 2 +-
 samples/bpf/xdpsock_user.c | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/samples/bpf/xdpsock_kern.c b/samples/bpf/xdpsock_kern.c
index d8806c41362e..b8ccd0802b3f 100644
--- a/samples/bpf/xdpsock_kern.c
+++ b/samples/bpf/xdpsock_kern.c
@@ -16,7 +16,7 @@ struct bpf_map_def SEC("maps") xsks_map = {
        .type = BPF_MAP_TYPE_XSKMAP,
        .key_size = sizeof(int),
        .value_size = sizeof(int),
-       .max_entries = 4,
+       .max_entries = MAX_SOCKS,
 };

 struct bpf_map_def SEC("maps") rr_map = {
diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c
index b3906111bedb..57ecadc58403 100644
--- a/samples/bpf/xdpsock_user.c
+++ b/samples/bpf/xdpsock_user.c
@@ -118,7 +118,6 @@ struct xdpsock {
        unsigned long prev_tx_npkts;
 };

-#define MAX_SOCKS 4
 static int num_socks;
 struct xdpsock *xsks[MAX_SOCKS];
@@ -596,7 +595,7 @@ static void dump_stats(void)

        prev_time = now;

-       for (i = 0; i < num_socks; i++) {
+       for (i = 0; i < num_socks && xsks[i]; i++) {
                char *fmt = "%-15s %'-11.0f %'-11lu\n";
                double rx_pps, tx_pps;

--
2.17.1

Re: [PATCH bpf-next] samples/bpf: xdpsock, minor fixes

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2018-08-31 15:24:42

On 08/31/2018 03:00 AM, Prashant Bhole wrote:
- xsks_map size was fixed to 4, changed it MAX_SOCKS
- Remove redundant definition of MAX_SOCKS in xdpsock_user.c
- In dump_stats(), add NULL check for xsks[i]

Signed-off-by: Prashant Bhole <redacted>
Applied, thanks Prashant!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help