[PATCH net-next] tipc: add missing dev_put() on error in tipc_enable_l2_media

Subsystems: networking [general], the rest, tipc network layer

STALE2944d

3 messages, 3 authors, 2018-07-26 · open the first message on its own page

[PATCH net-next] tipc: add missing dev_put() on error in tipc_enable_l2_media

From: YueHaibing <hidden>
Date: 2018-07-25 10:01:11

when tipc_own_id failed to obtain node identity,dev_put should
be call before return -EINVAL.

Fixes: 682cd3cf946b ("tipc: confgiure and apply UDP bearer MTU on running links")
Signed-off-by: YueHaibing <redacted>
---
 net/tipc/bearer.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index fd6d8f1..418f03d 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c
@@ -395,6 +395,7 @@ int tipc_enable_l2_media(struct net *net, struct tipc_bearer *b,
 		tipc_net_init(net, node_id, 0);
 	}
 	if (!tipc_own_id(net)) {
+		dev_put(dev);
 		pr_warn("Failed to obtain node identity\n");
 		return -EINVAL;
 	}
-- 
2.7.0

RE: [PATCH net-next] tipc: add missing dev_put() on error in tipc_enable_l2_media

From: Jon Maloy <hidden>
Date: 2018-07-26 02:19:02

Acked
///Jon Maloy
quoted hunk
-----Original Message-----
From: netdev-owner@vger.kernel.org <redacted> On Behalf Of YueHaibing
Sent: Wednesday, 25 July, 2018 05:01
To: davem@davemloft.net; Jon Maloy <redacted>; ying.xue@windriver.com
Cc: linux-kernel@vger.kernel.org; netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net; YueHaibing
[off-list ref]
Subject: [PATCH net-next] tipc: add missing dev_put() on error in tipc_enable_l2_media

when tipc_own_id failed to obtain node identity,dev_put should
be call before return -EINVAL.

Fixes: 682cd3cf946b ("tipc: confgiure and apply UDP bearer MTU on running links")
Signed-off-by: YueHaibing <redacted>
---
 net/tipc/bearer.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
index fd6d8f1..418f03d 100644
--- a/net/tipc/bearer.c
+++ b/net/tipc/bearer.c
@@ -395,6 +395,7 @@ int tipc_enable_l2_media(struct net *net, struct tipc_bearer *b,
 		tipc_net_init(net, node_id, 0);
 	}
 	if (!tipc_own_id(net)) {
+		dev_put(dev);
 		pr_warn("Failed to obtain node identity\n");
 		return -EINVAL;
 	}
--
2.7.0

Re: [PATCH net-next] tipc: add missing dev_put() on error in tipc_enable_l2_media

From: David Miller <davem@davemloft.net>
Date: 2018-07-26 21:05:53

From: YueHaibing <redacted>
Date: Wed, 25 Jul 2018 18:00:49 +0800
when tipc_own_id failed to obtain node identity,dev_put should
be call before return -EINVAL.

Fixes: 682cd3cf946b ("tipc: confgiure and apply UDP bearer MTU on running links")
Signed-off-by: YueHaibing <redacted>
Applied to net-next, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help