[PATCH] net: sched: use PTR_ERR_OR_ZERO macro in tcf_block_cb_register

Subsystems: networking [general], tc subsystem, the rest

STALE2945d

2 messages, 2 authors, 2018-07-21 · open the first message on its own page

[PATCH] net: sched: use PTR_ERR_OR_ZERO macro in tcf_block_cb_register

From: Gustavo A. R. Silva <hidden>
Date: 2018-07-19 04:16:14

This line makes up what macro PTR_ERR_OR_ZERO already does. So,
make use of PTR_ERR_OR_ZERO rather than an open-code version.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <redacted>
---
 net/sched/cls_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index c51b1b1..570325f 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -818,7 +818,7 @@ int tcf_block_cb_register(struct tcf_block *block,
 
 	block_cb = __tcf_block_cb_register(block, cb, cb_ident, cb_priv,
 					   extack);
-	return IS_ERR(block_cb) ? PTR_ERR(block_cb) : 0;
+	return PTR_ERR_OR_ZERO(block_cb);
 }
 EXPORT_SYMBOL(tcf_block_cb_register);
 
-- 
2.7.4

Re: [PATCH] net: sched: use PTR_ERR_OR_ZERO macro in tcf_block_cb_register

From: David Miller <davem@davemloft.net>
Date: 2018-07-21 23:17:50

From: "Gustavo A. R. Silva" <redacted>
Date: Wed, 18 Jul 2018 23:14:17 -0500
This line makes up what macro PTR_ERR_OR_ZERO already does. So,
make use of PTR_ERR_OR_ZERO rather than an open-code version.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <redacted>
Applied to net-next, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help