[PATCH] net/rds: void function cannot return -1

Subsystems: networking [general], rds - reliable datagram sockets, the rest

STALE2947d

3 messages, 3 authors, 2018-07-18 · open the first message on its own page

[PATCH] net/rds: void function cannot return -1

From: Håkon Bugge <hidden>
Date: 2018-07-16 13:00:43

Commit b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") did
not change the comment accordingly.

Fixes: b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void")
Signed-off-by: Håkon Bugge <redacted>
---
 net/rds/ib_recv.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c
index b4e421aa9727..e5ce93419263 100644
--- a/net/rds/ib_recv.c
+++ b/net/rds/ib_recv.c
@@ -376,8 +376,6 @@ static void release_refill(struct rds_connection *conn)
  * This tries to allocate and post unused work requests after making sure that
  * they have all the allocations they need to queue received fragments into
  * sockets.
- *
- * -1 is returned if posting fails due to temporary resource exhaustion.
  */
 void rds_ib_recv_refill(struct rds_connection *conn, int prefill, gfp_t gfp)
 {
-- 
2.14.3

Re: [PATCH] net/rds: void function cannot return -1

From: Santosh Shilimkar <hidden>
Date: 2018-07-16 16:29:12

On 7/16/2018 6:00 AM, Håkon Bugge wrote:
quoted hunk
Commit b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") did
not change the comment accordingly.

Fixes: b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void")
Signed-off-by: Håkon Bugge <redacted>
---
  net/rds/ib_recv.c | 2 --
  1 file changed, 2 deletions(-)
diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c
index b4e421aa9727..e5ce93419263 100644
--- a/net/rds/ib_recv.c
+++ b/net/rds/ib_recv.c
@@ -376,8 +376,6 @@ static void release_refill(struct rds_connection *conn)
   * This tries to allocate and post unused work requests after making sure that
   * they have all the allocations they need to queue received fragments into
   * sockets.
- *
- * -1 is returned if posting fails due to temporary resource exhaustion.
   */
  void rds_ib_recv_refill(struct rds_connection *conn, int prefill, gfp_t gfp)
  {
Yep. Thanks !!

Acked-by: Santosh Shilimkar <redacted>

Re: [PATCH] net/rds: void function cannot return -1

From: David Miller <davem@davemloft.net>
Date: 2018-07-18 05:44:30

From: Håkon Bugge <redacted>
Date: Mon, 16 Jul 2018 15:00:09 +0200
Commit b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void") did
not change the comment accordingly.

Fixes: b6fb0df12db6 ("RDS/IB: Make ib_recv_refill return void")
Signed-off-by: Håkon Bugge <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help