DORMANTno replies

[PATCH] Add a missing break in parse_station_flags

From: Bernd Edlinger <hidden>
Date: 2018-07-08 09:57:33
Also in: linux-wireless, lkml
Subsystem: 802.11 (including cfg80211/nl80211), the rest · Maintainers: Johannes Berg, Linus Torvalds

I was looking at usually suppressed gcc warnings,
[-Wimplicit-fallthrough=] in this case:

The code definitely looks like a break is missing here.
However I am not able to test the NL80211_IFTYPE_MESH_POINT,
nor do I actually know what might be :)
So please use this patch with caution and only if you are
able to do some testing.

Signed-off-by: Bernd Edlinger <redacted>
---
  net/wireless/nl80211.c | 1 +
  1 file changed, 1 insertion(+)
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 4eece06..6537b5d 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -4409,6 +4409,7 @@ static int parse_station_flags(struct genl_info *info,
  		params->sta_flags_mask = BIT(NL80211_STA_FLAG_AUTHENTICATED) |
  					 BIT(NL80211_STA_FLAG_MFP) |
  					 BIT(NL80211_STA_FLAG_AUTHORIZED);
+		break;
  	default:
  		return -EINVAL;
  	}
-- 
1.9.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help