[PATCH] net: ethernet: nb8800: remove redundant pointer rxd

Subsystems: networking drivers, the rest

STALE2966d

2 messages, 2 authors, 2018-07-04 · open the first message on its own page

[PATCH] net: ethernet: nb8800: remove redundant pointer rxd

From: Colin King <hidden>
Date: 2018-07-04 07:20:29

From: Colin Ian King <redacted>

Pointer rxd is being assigned but is never used hence it is
redundant and can be removed.

Cleans up clang warning:
warning: variable 'rxb' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/aurora/nb8800.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
index e94159507847..c8d1f8fa4713 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -304,12 +304,10 @@ static int nb8800_poll(struct napi_struct *napi, int budget)
 
 again:
 	do {
-		struct nb8800_rx_buf *rxb;
 		unsigned int len;
 
 		next = (last + 1) % RX_DESC_COUNT;
 
-		rxb = &priv->rx_bufs[next];
 		rxd = &priv->rx_descs[next];
 
 		if (!rxd->report)
-- 
2.17.1

Re: [PATCH] net: ethernet: nb8800: remove redundant pointer rxd

From: David Miller <davem@davemloft.net>
Date: 2018-07-04 13:45:00

From: Colin King <redacted>
Date: Wed,  4 Jul 2018 08:20:20 +0100
From: Colin Ian King <redacted>

Pointer rxd is being assigned but is never used hence it is
redundant and can be removed.

Cleans up clang warning:
warning: variable 'rxb' set but not used [-Wunused-but-set-variable]

Signed-off-by: Colin Ian King <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help