[PATCH iproute2] tc: Fix output of ip attributes

Subsystems: the rest

STALE2957d

2 messages, 2 authors, 2018-07-07 · open the first message on its own page

[PATCH iproute2] tc: Fix output of ip attributes

From: Roi Dayan <hidden>
Date: 2018-07-03 12:54:37

Example output is of tos and ttl.
Befoe this fix the format used %x caused output of the pointer
instead of the intended string created in the out variable.

Fixes: e28b88a464c4 ("tc: jsonify flower filter")
Signed-off-by: Roi Dayan <redacted>
---
 tc/f_flower.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/f_flower.c b/tc/f_flower.c
index c710765179fb..1dfd57d286d9 100644
--- a/tc/f_flower.c
+++ b/tc/f_flower.c
@@ -1134,7 +1134,7 @@ static void flower_print_ip_attr(char *name, struct rtattr *key_attr,
 	if (mask_attr)
 		sprintf(out + done, "/%x", rta_getattr_u8(mask_attr));
 
-	sprintf(namefrm, "\n  %s %%x", name);
+	sprintf(namefrm, "\n  %s %%s", name);
 	print_string(PRINT_ANY, name, namefrm, out);
 }
 
-- 
2.7.5

Re: [PATCH iproute2] tc: Fix output of ip attributes

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2018-07-07 17:00:16

On Tue,  3 Jul 2018 15:54:32 +0300
Roi Dayan [off-list ref] wrote:
Example output is of tos and ttl.
Befoe this fix the format used %x caused output of the pointer
instead of the intended string created in the out variable.

Fixes: e28b88a464c4 ("tc: jsonify flower filter")
Signed-off-by: Roi Dayan <redacted>
Applied. 

It would be better to use snprintf to be safe.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help