[PATCH] sfc: make function efx_rps_hash_bucket static

Subsystems: networking drivers, sfc network driver, the rest

STALE2972d

2 messages, 2 authors, 2018-06-24 · open the first message on its own page

[PATCH] sfc: make function efx_rps_hash_bucket static

From: Colin King <hidden>
Date: 2018-06-24 10:57:38

From: Colin Ian King <redacted>

The function efx_rps_hash_bucket is local to the source and
does not need to be in global scope, so make it static.

Cleans up sparse warning:
symbol 'efx_rps_hash_bucket' was not declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/sfc/efx.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index ad4a354ce570..570ec72266f3 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -3180,6 +3180,7 @@ bool efx_rps_check_rule(struct efx_arfs_rule *rule, unsigned int filter_idx,
 	return true;
 }
 
+static
 struct hlist_head *efx_rps_hash_bucket(struct efx_nic *efx,
 				       const struct efx_filter_spec *spec)
 {
-- 
2.17.0

Re: [PATCH] sfc: make function efx_rps_hash_bucket static

From: David Miller <davem@davemloft.net>
Date: 2018-06-24 14:11:42

From: Colin King <redacted>
Date: Sun, 24 Jun 2018 11:57:31 +0100
From: Colin Ian King <redacted>

The function efx_rps_hash_bucket is local to the source and
does not need to be in global scope, so make it static.

Cleans up sparse warning:
symbol 'efx_rps_hash_bucket' was not declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help