[PATCH] net: ethernet: ti: davinci_cpdma: make function cpdma_desc_pool_create static

Subsystems: networking drivers, the rest, ti ethernet switch driver (cpsw)

STALE2962d

3 messages, 3 authors, 2018-06-22 · open the first message on its own page

[PATCH] net: ethernet: ti: davinci_cpdma: make function cpdma_desc_pool_create static

From: Colin King <hidden>
Date: 2018-06-21 17:16:52 

From: Colin Ian King <redacted>

The function cpdma_desc_pool_create is local to the source and does not
need to be in global scope, so make it static.

Cleans up sparse warning:
warning: symbol 'cpdma_desc_pool_create' was not declared. Should it
be static?

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/ti/davinci_cpdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
index cdbddf16dd29..4f1267477aa4 100644
--- a/drivers/net/ethernet/ti/davinci_cpdma.c
+++ b/drivers/net/ethernet/ti/davinci_cpdma.c
@@ -205,7 +205,7 @@ static void cpdma_desc_pool_destroy(struct cpdma_ctlr *ctlr)
  * devices (e.g. cpsw switches) use plain old memory.  Descriptor pools
  * abstract out these details
  */
-int cpdma_desc_pool_create(struct cpdma_ctlr *ctlr)
+static int cpdma_desc_pool_create(struct cpdma_ctlr *ctlr)
 {
 	struct cpdma_params *cpdma_params = &ctlr->params;
 	struct cpdma_desc_pool *pool;
-- 
2.17.0

Re: [PATCH] net: ethernet: ti: davinci_cpdma: make function cpdma_desc_pool_create static

From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: 2018-06-21 17:22:48 

Please, add netdev@vger.kernel.org for the future

On 06/21/2018 12:16 PM, Colin King wrote:
quoted hunk
From: Colin Ian King <redacted>

The function cpdma_desc_pool_create is local to the source and does not
need to be in global scope, so make it static.

Cleans up sparse warning:
warning: symbol 'cpdma_desc_pool_create' was not declared. Should it
be static?

Signed-off-by: Colin Ian King <redacted>
---
  drivers/net/ethernet/ti/davinci_cpdma.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
index cdbddf16dd29..4f1267477aa4 100644
--- a/drivers/net/ethernet/ti/davinci_cpdma.c
+++ b/drivers/net/ethernet/ti/davinci_cpdma.c
@@ -205,7 +205,7 @@ static void cpdma_desc_pool_destroy(struct cpdma_ctlr *ctlr)
   * devices (e.g. cpsw switches) use plain old memory.  Descriptor pools
   * abstract out these details
   */
-int cpdma_desc_pool_create(struct cpdma_ctlr *ctlr)
+static int cpdma_desc_pool_create(struct cpdma_ctlr *ctlr)
  {
  	struct cpdma_params *cpdma_params = &ctlr->params;
  	struct cpdma_desc_pool *pool;
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

-- 
regards,
-grygorii

Re: [PATCH] net: ethernet: ti: davinci_cpdma: make function cpdma_desc_pool_create static

From: David Miller <davem@davemloft.net>
Date: 2018-06-22 00:32:02 

From: Colin King <redacted>
Date: Thu, 21 Jun 2018 18:16:45 +0100

From: Colin Ian King <redacted>

The function cpdma_desc_pool_create is local to the source and does not
need to be in global scope, so make it static.

Cleans up sparse warning:
warning: symbol 'cpdma_desc_pool_create' was not declared. Should it
be static?

Signed-off-by: Colin Ian King <redacted>
Applied, thanks Colin.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help