[PATCH] selftests/net: Fix permissions for fib_tests.sh

Subsystems: kernel selftest framework, networking [general], networking [ipv4/ipv6], the rest

STALE2958d

3 messages, 3 authors, 2018-06-28 · open the first message on its own page

[PATCH] selftests/net: Fix permissions for fib_tests.sh

From: Daniel Díaz <hidden>
Date: 2018-06-19 16:21:08

fib_tests.sh became non-executable at some point. This is
what happens:
  selftests: net: fib_tests.sh: Warning: file fib_tests.sh is
  not executable, correct this.
  not ok 1..11 selftests: net: fib_tests.sh [FAIL]

Fixes: d69faad76584 ("selftests: fib_tests: Add prefix route tests with metric")

Signed-off-by: Daniel Díaz <redacted>
---
 tools/testing/selftests/net/fib_tests.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/net/fib_tests.sh
diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
old mode 100644
new mode 100755
-- 
2.7.4

Re: [PATCH] selftests/net: Fix permissions for fib_tests.sh

From: Shuah Khan <shuah@kernel.org>
Date: 2018-06-26 18:22:48

On 06/19/2018 10:20 AM, Daniel Díaz wrote:
quoted hunk
fib_tests.sh became non-executable at some point. This is
what happens:
  selftests: net: fib_tests.sh: Warning: file fib_tests.sh is
  not executable, correct this.
  not ok 1..11 selftests: net: fib_tests.sh [FAIL]

Fixes: d69faad76584 ("selftests: fib_tests: Add prefix route tests with metric")

Signed-off-by: Daniel Díaz <redacted>
---
 tools/testing/selftests/net/fib_tests.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/net/fib_tests.sh
diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
old mode 100644
new mode 100755
Hi David,

Are you planning to pick this up for 4.18-rc3 or later?

Acked-by: Shuah Khan <shuah@kernel.org>

thanks,
-- Shuah

Re: [PATCH] selftests/net: Fix permissions for fib_tests.sh

From: David Miller <davem@davemloft.net>
Date: 2018-06-28 07:15:52

From: Shuah Khan <shuah@kernel.org>
Date: Tue, 26 Jun 2018 12:22:28 -0600
On 06/19/2018 10:20 AM, Daniel Díaz wrote:
quoted
fib_tests.sh became non-executable at some point. This is
what happens:
  selftests: net: fib_tests.sh: Warning: file fib_tests.sh is
  not executable, correct this.
  not ok 1..11 selftests: net: fib_tests.sh [FAIL]

Fixes: d69faad76584 ("selftests: fib_tests: Add prefix route tests with metric")

Signed-off-by: Daniel Díaz <redacted>
---
 tools/testing/selftests/net/fib_tests.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/net/fib_tests.sh
diff --git a/tools/testing/selftests/net/fib_tests.sh b/tools/testing/selftests/net/fib_tests.sh
old mode 100644
new mode 100755
Hi David,

Are you planning to pick this up for 4.18-rc3 or later?
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help