[PATCH] r8169: Fix netpoll oops
Subsystems:
8169 10/100/1000 gigabit ethernet driver , networking drivers , the rest
STALE2963d
3 messages,
3 authors,
2018-06-21
· open the first message on its own page
From: Ville Syrjälä <redacted>
Pass the correct thing to rtl8169_interrupt() from netpoll.
Cc: Realtek linux nic maintainers <redacted>
Cc: netdev@vger.kernel.org
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Fixes: ebcd5daa7ffd ("r8169: change interrupt handler argument type")
Signed-off-by: Ville Syrjälä <redacted>
---
drivers/net/ethernet/realtek/r8169.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 75dfac0248f4..f4cae2be0fda 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c @@ -7148,7 +7148,7 @@ static void rtl8169_netpoll(struct net_device *dev)
{
struct rtl8169_private * tp = netdev_priv ( dev );
- rtl8169_interrupt ( pci_irq_vector ( tp -> pci_dev , 0 ), dev );
+ rtl8169_interrupt ( pci_irq_vector ( tp -> pci_dev , 0 ), tp );
}
#endif
--
2.16.4
On 20.06.2018 14:01, Ville Syrjala wrote: From: Ville Syrjälä <redacted>
Pass the correct thing to rtl8169_interrupt() from netpoll. Indeed, this place I missed to change.
Only small remark: The patch should be annotated as "net" so
that it can go to 4.18.
quoted hunk Cc: Realtek linux nic maintainers <redacted>
Cc: netdev@vger.kernel.org
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Fixes: ebcd5daa7ffd ("r8169: change interrupt handler argument type")
Signed-off-by: Ville Syrjälä <redacted>
---
drivers/net/ethernet/realtek/r8169.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 75dfac0248f4..f4cae2be0fda 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c @@ -7148,7 +7148,7 @@ static void rtl8169_netpoll(struct net_device *dev)
{
struct rtl8169_private * tp = netdev_priv ( dev );
- rtl8169_interrupt ( pci_irq_vector ( tp -> pci_dev , 0 ), dev );
+ rtl8169_interrupt ( pci_irq_vector ( tp -> pci_dev , 0 ), tp );
}
#endif
From: Ville Syrjala <redacted>
Date: Wed, 20 Jun 2018 15:01:53 +0300
From: Ville Syrjälä <redacted>
Pass the correct thing to rtl8169_interrupt() from netpoll.
Cc: Realtek linux nic maintainers <redacted>
Cc: netdev@vger.kernel.org
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Fixes: ebcd5daa7ffd ("r8169: change interrupt handler argument type")
Signed-off-by: Ville Syrjälä <redacted>
Applied.