Hi,
The following series is for mlx5-next tree [1], it adds the support of two
new device events, from Ilan Tayari:
1. High temperature warnings.
2. FPGA QP error event.
In case of no objection this series will be applied to mlx5-next tree
and will be sent later as a pull request to both rdma and net trees.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next
v1->v2:
- improve commit message of the FPGA QP error event patch.
Thanks,
Saeed.
Ilan Tayari (2):
net/mlx5: Add temperature warning event to log
net/mlx5: Add FPGA QP error event
drivers/net/ethernet/mellanox/mlx5/core/eq.c | 28 +++++++++++++++++++-
include/linux/mlx5/device.h | 8 ++++++
include/linux/mlx5/mlx5_ifc.h | 3 ++-
include/linux/mlx5/mlx5_ifc_fpga.h | 16 +++++++++++
4 files changed, 53 insertions(+), 2 deletions(-)
--
2.17.0
From: Ilan Tayari <redacted>
Temperature warning event is sent by FW to indicate high temperature
as detected by one of the sensors on the board.
Add handling of this event by writing the numbers of the alert sensors
to the kernel log.
Signed-off-by: Ilan Tayari <redacted>
Signed-off-by: Adi Nissim <redacted>
Signed-off-by: Saeed Mahameed <redacted>
---
drivers/net/ethernet/mellanox/mlx5/core/eq.c | 23 ++++++++++++++++++++
include/linux/mlx5/device.h | 7 ++++++
include/linux/mlx5/mlx5_ifc.h | 2 +-
3 files changed, 31 insertions(+), 1 deletion(-)
@@ -393,6 +395,20 @@ static void general_event_handler(struct mlx5_core_dev *dev,}}+staticvoidmlx5_temp_warning_event(structmlx5_core_dev*dev,+structmlx5_eqe*eqe)+{+u64value_lsb;+u64value_msb;++value_lsb=be64_to_cpu(eqe->data.temp_warning.sensor_warning_lsb);+value_msb=be64_to_cpu(eqe->data.temp_warning.sensor_warning_msb);++mlx5_core_warn(dev,+"High temperature on sensors with bit set %llx %llx",+value_msb,value_lsb);+}+/* caller must eventually call mlx5_cq_put on the returned cq */staticstructmlx5_core_cq*mlx5_eq_cq_get(structmlx5_eq*eq,u32cqn){
From: Ilan Tayari <redacted>
The FPGA queue pair (QP) event fires whenever a QP on the FPGA
transitions to the error state.
At this stage, this event is unrecoverable, it may become recoverable
in the future.
Signed-off-by: Ilan Tayari <redacted>
Signed-off-by: Adi Nissim <redacted>
Signed-off-by: Saeed Mahameed <redacted>
---
drivers/net/ethernet/mellanox/mlx5/core/eq.c | 7 +++++--
include/linux/mlx5/device.h | 1 +
include/linux/mlx5/mlx5_ifc.h | 1 +
include/linux/mlx5/mlx5_ifc_fpga.h | 16 ++++++++++++++++
4 files changed, 23 insertions(+), 2 deletions(-)
On Wed, 2018-05-30 at 10:59 -0700, Saeed Mahameed wrote:
Hi,
The following series is for mlx5-next tree [1], it adds the support of two
new device events, from Ilan Tayari:
1. High temperature warnings.
2. FPGA QP error event.
In case of no objection this series will be applied to mlx5-next tree
and will be sent later as a pull request to both rdma and net trees.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next
v1->v2:
- improve commit message of the FPGA QP error event patch.
Thanks,
Saeed.
Ilan Tayari (2):
net/mlx5: Add temperature warning event to log
net/mlx5: Add FPGA QP error event
drivers/net/ethernet/mellanox/mlx5/core/eq.c | 28 +++++++++++++++++++-
include/linux/mlx5/device.h | 8 ++++++
include/linux/mlx5/mlx5_ifc.h | 3 ++-
include/linux/mlx5/mlx5_ifc_fpga.h | 16 +++++++++++
4 files changed, 53 insertions(+), 2 deletions(-)
The following series is for mlx5-next tree [1], it adds the support of two
new device events, from Ilan Tayari:
1. High temperature warnings.
2. FPGA QP error event.
In case of no objection this series will be applied to mlx5-next tree
and will be sent later as a pull request to both rdma and net trees.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next
v1->v2:
- improve commit message of the FPGA QP error event patch.
The following series is for mlx5-next tree [1], it adds the support of two
new device events, from Ilan Tayari:
1. High temperature warnings.
2. FPGA QP error event.
In case of no objection this series will be applied to mlx5-next tree
and will be sent later as a pull request to both rdma and net trees.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next
v1->v2:
- improve commit message of the FPGA QP error event patch.
Series applied, thanks.
Hi Dave,
Although in this case it doesn't really matter and we can work around
it, this was supposed to be a case of the new methodology that Saeed and
Jason had worked out with you. Specifically, when Saeed says in the
cover letter:
In case of no objection this series will be applied to mlx5-next tree>
and will be sent later as a pull request to both rdma and net trees.
then it is intended for you to ack the original patch series, not apply
it, and when acks from both the net and rdma side have been received,
then we will get a pull request of just that series.
--
Doug Ledford [off-list ref]
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
The following series is for mlx5-next tree [1], it adds the support of two
new device events, from Ilan Tayari:
1. High temperature warnings.
2. FPGA QP error event.
In case of no objection this series will be applied to mlx5-next tree
and will be sent later as a pull request to both rdma and net trees.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next
v1->v2:
- improve commit message of the FPGA QP error event patch.
Series applied, thanks.
Hi Dave,
Although in this case it doesn't really matter and we can work around
it, this was supposed to be a case of the new methodology that Saeed and
Jason had worked out with you. Specifically, when Saeed says in the
cover letter:
quoted
In case of no objection this series will be applied to mlx5-next tree>
and will be sent later as a pull request to both rdma and net trees.
then it is intended for you to ack the original patch series, not apply
it, and when acks from both the net and rdma side have been received,
then we will get a pull request of just that series.
Sorry, I saw your ACK and misinterpreted the situation.
I'll be more careful next time.
The following series is for mlx5-next tree [1], it adds the support of two
new device events, from Ilan Tayari:
1. High temperature warnings.
2. FPGA QP error event.
In case of no objection this series will be applied to mlx5-next tree
and will be sent later as a pull request to both rdma and net trees.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next
v1->v2:
- improve commit message of the FPGA QP error event patch.
Series applied, thanks.
Hi Dave,
Although in this case it doesn't really matter and we can work around
it, this was supposed to be a case of the new methodology that Saeed and
Jason had worked out with you. Specifically, when Saeed says in the
cover letter:
quoted
In case of no objection this series will be applied to mlx5-next tree>
and will be sent later as a pull request to both rdma and net trees.
then it is intended for you to ack the original patch series, not apply
it, and when acks from both the net and rdma side have been received,
then we will get a pull request of just that series.
Sorry, I saw your ACK and misinterpreted the situation.
I'll be more careful next time.
Doug, Dave
I would like to clarify this point, we intend to send pull request to only
one maintainer, who actually needs the accepted patches.
Let's take the RDMA flow counters series as an example:
https://www.spinics.net/lists/linux-rdma/msg65620.html
This series includes 12 patches for RDMA and 2 shared code
(mlx5-next). Those two patches, the RDMA side will receive as part
of specific pull request and netdev will get them if some netdev
feature down the road will need mlx5-next branch.
Of course, it is harmless for both of you to pull, but it looks like
extra work which is not needed for you.
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The following series is for mlx5-next tree [1], it adds the support of two
new device events, from Ilan Tayari:
1. High temperature warnings.
2. FPGA QP error event.
In case of no objection this series will be applied to mlx5-next tree
and will be sent later as a pull request to both rdma and net trees.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next
v1->v2:
- improve commit message of the FPGA QP error event patch.
Series applied, thanks.
Hi Dave,
Although in this case it doesn't really matter and we can work around
it, this was supposed to be a case of the new methodology that Saeed and
Jason had worked out with you. Specifically, when Saeed says in the
cover letter:
quoted
In case of no objection this series will be applied to mlx5-next tree>
and will be sent later as a pull request to both rdma and net trees.
then it is intended for you to ack the original patch series, not apply
it, and when acks from both the net and rdma side have been received,
then we will get a pull request of just that series.
Sorry, I saw your ACK and misinterpreted the situation.
I'll be more careful next time.
Doug, Dave
I would like to clarify this point, we intend to send pull request to only
one maintainer, who actually needs the accepted patches.
Let's take the RDMA flow counters series as an example:
https://www.spinics.net/lists/linux-rdma/msg65620.html
This series includes 12 patches for RDMA and 2 shared code
(mlx5-next). Those two patches, the RDMA side will receive as part
of specific pull request and netdev will get them if some netdev
feature down the road will need mlx5-next branch.
Of course, it is harmless for both of you to pull, but it looks like
extra work which is not needed for you.
The following series is for mlx5-next tree [1], it adds the support of two
new device events, from Ilan Tayari:
1. High temperature warnings.
2. FPGA QP error event.
In case of no objection this series will be applied to mlx5-next tree
and will be sent later as a pull request to both rdma and net trees.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.git/log/?h=mlx5-next
v1->v2:
- improve commit message of the FPGA QP error event patch.
Series applied, thanks.
Hi Dave,
Although in this case it doesn't really matter and we can work around
it, this was supposed to be a case of the new methodology that Saeed and
Jason had worked out with you. Specifically, when Saeed says in the
cover letter:
quoted
In case of no objection this series will be applied to mlx5-next tree>
and will be sent later as a pull request to both rdma and net trees.
then it is intended for you to ack the original patch series, not apply
it, and when acks from both the net and rdma side have been received,
then we will get a pull request of just that series.
Sorry, I saw your ACK and misinterpreted the situation.
I'll be more careful next time.
From: Leon Romanovsky <hidden> Date: 2018-06-01 19:30:39
On Fri, Jun 01, 2018 at 01:08:18PM -0400, David Miller wrote:
From: Leon Romanovsky <redacted>
Date: Fri, 1 Jun 2018 19:21:26 +0300
quoted
Of course, it is harmless for both of you to pull, but it looks like
extra work which is not needed for you.
Just put net-next or rdma-next in the subject line(s) and that will
make it very clear what it expected to happen.
It was our intention too.
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The following series is for mlx5-next tree [1], it adds the support
of two
new device events, from Ilan Tayari:
1. High temperature warnings.
2. FPGA QP error event.
In case of no objection this series will be applied to mlx5-next
tree
and will be sent later as a pull request to both rdma and net
trees.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linux.
git/log/?h=mlx5-next
v1->v2:
- improve commit message of the FPGA QP error event patch.
Series applied, thanks.
Hey Dave, this series was meant to go to mlx5-next tree as stated in
the cover letter and patches titles "[PATCH V2 mlx5-next 0/2]".
It is ok you applied those patches to net-next this time, but for next
time I would like to apply them myself to mlx5-next and send a clean
pull request later to both rdma and net trees.
Is there a way for me to mark them as delegated in patchwork ?
I see that i have "update Properties" option in patchwork but i don't
know how to use it or whether I am allowed to do anything with it.
Thanks,
Saeed.
The following series is for mlx5-next tree [1], it adds the
support
of two
new device events, from Ilan Tayari:
1. High temperature warnings.
2. FPGA QP error event.
In case of no objection this series will be applied to mlx5-next
tree
and will be sent later as a pull request to both rdma and net
trees.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mellanox/linu
x.
git/log/?h=mlx5-next
v1->v2:
- improve commit message of the FPGA QP error event patch.
Series applied, thanks.
Hey Dave, this series was meant to go to mlx5-next tree as stated in
the cover letter and patches titles "[PATCH V2 mlx5-next 0/2]".
It is ok you applied those patches to net-next this time, but for
next
time I would like to apply them myself to mlx5-next and send a clean
pull request later to both rdma and net trees.
Sorry please ignore, I just saw that this was sorted out .. :).
Thanks A lot !
Is there a way for me to mark them as delegated in patchwork ?
I see that i have "update Properties" option in patchwork but i don't
know how to use it or whether I am allowed to do anything with it.
It would be great if we can mark such patches in patchwork though..
On Fri, 2018-06-01 at 17:13 -0700, saeedm@mellanox.com wrote:
quoted
Hey Dave, this series was meant to go to mlx5-next tree as stated in
the cover letter and patches titles "[PATCH V2 mlx5-next 0/2]".
It is ok you applied those patches to net-next this time, but for
next
time I would like to apply them myself to mlx5-next and send a clean
pull request later to both rdma and net trees.
Sorry please ignore, I just saw that this was sorted out .. :).
Thanks A lot !
quoted
Is there a way for me to mark them as delegated in patchwork ?
I see that i have "update Properties" option in patchwork but i don't
know how to use it or whether I am allowed to do anything with it.
It would be great if we can mark such patches in patchwork though..
I really don't like it when others adjust patchwork state on me.
Florian Fainelli did it for a brief time for some of his own patches
and it caused a lot of confusion for me, so I asked him to stop.
Let's just make sure that the Subject line says mlx5-next or whatever
instead of net-next and I'll be mindful in such situations.
Thanks.