[PATCH 2/2] bpf: sockmap, potential uninitialized return in __sock_map_ctx_update_elem()
From: Dan Carpenter <hidden>
Date: 2018-05-18 07:59:24
Also in:
kernel-janitors
Subsystem:
bpf [general] (safe dynamic programs and tools), the rest · Maintainers:
Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, Eduard Zingerman, Kumar Kartikeya Dwivedi, Linus Torvalds
Smatch complains that "err" might be uninitialized. That seems
possible. Anyway we can just return zero.
Fixes: e5cd3abcb31a ("bpf: sockmap, refactor sockmap routines to work with hashmap")
Signed-off-by: Dan Carpenter <redacted>
diff --git a/kernel/bpf/sockmap.c b/kernel/bpf/sockmap.c
index c6de1393df63..6298adb3162a 100644
--- a/kernel/bpf/sockmap.c
+++ b/kernel/bpf/sockmap.c@@ -1821,7 +1821,7 @@ static int __sock_map_ctx_update_elem(struct bpf_map *map, list_add_tail(&e->list, &psock->maps); } write_unlock_bh(&sock->sk_callback_lock); - return err; + return 0; out_free: kfree(e); smap_release_sock(psock, sock);