# Re: \[PATCH 2/2\] staging: irda: Replace mdelay with usleep\_range in irda\_usb\_probe

- From: Johan Hovold \<johan@kernel.org\>
- Date: 2018-04-11 07:08:20 
- List: netdev
- Page: https://ratatoskr.run/netdev/2018/04/5254337
- Thread: https://ratatoskr.run/netdev/2018/04/5254336/t.md

```text
On Wed, Apr 11, 2018 at 09:33:55AM +0800, Jia-Ju Bai wrote:
> irda_usb_probe() is never called in atomic context.
> 
> irda_usb_probe() is only set as ".probe" in struct usb_driver.
> 
> Despite never getting called from atomic context, irda_usb_probe()
> calls mdelay() to busily wait.
> This is not necessary and can be replaced with usleep_range() to
> avoid busy waiting.
> 
> This is found by a static analysis tool named DCNS written by myself.
> And I also manually check it.
> 
> Signed-off-by: Jia-Ju Bai <redacted>

Reviewed-by: Johan Hovold <johan@kernel.org>
```
