# Re: \[PATCH net-next v3 1/3\] vmcore: add API to collect hardware dump in second kernel

- From: kbuild test robot \<hidden\>
- Date: 2018-04-01 00:33:28 
- List: netdev
- Page: https://ratatoskr.run/netdev/2018/04/133018
- Thread: https://ratatoskr.run/netdev/2018/03/133296/t.md

```text
Hi Rahul,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Rahul-Lakkireddy/kernel-add-support-to-collect-hardware-logs-in-crash-recovery-kernel/20180401-060904
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> fs/proc/vmcore.c:1199:5: sparse: symbol '__vmcore_add_device_dump' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
```
