Re: [PATCH net-next 2/2] net: cdc_eem: clean up bind error path

DORMANTno replies REVIEWED: 19 (19M)

From: Greg KH <hidden>
Date: 2018-03-07 14:56:50
Also in: linux-usb

1 review trailer.

On Wed, Mar 07, 2018 at 10:46:58AM +0100, Johan Hovold wrote:
Drop bogus call to usb_driver_release_interface() from an error path in
the usbnet bind() callback, which is called during interface probe. At
this point the interface is not bound and usb_driver_release_interface()
returns early.

Also remove the bogus call to clear the interface data, which is owned
by the usbnet driver and would not even have been set by the time bind()
is called.

Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help