[PATCH] net: gemini: fix memory leak

Subsystems: arm/cortina systems gemini arm architecture, networking drivers, the rest

STALE3134d

3 messages, 3 authors, 2018-03-20 · open the first message on its own page

[PATCH] net: gemini: fix memory leak

From: Igor Pylypiv <hidden>
Date: 2018-03-19 06:40:51

cppcheck report:
[drivers/net/ethernet/cortina/gemini.c:543]: (error) Memory leak: skb_tab

Signed-off-by: Igor Pylypiv <redacted>
---
 drivers/net/ethernet/cortina/gemini.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
index 5eb999a..bd3f6e4 100644
--- a/drivers/net/ethernet/cortina/gemini.c
+++ b/drivers/net/ethernet/cortina/gemini.c
@@ -540,6 +540,7 @@ static int gmac_setup_txqs(struct net_device *netdev)
 
 	if (port->txq_dma_base & ~DMA_Q_BASE_MASK) {
 		dev_warn(geth->dev, "TX queue base it not aligned\n");
+		kfree(skb_tab);
 		return -ENOMEM;
 	}
 
-- 
2.7.4

[PATCH] net: gemini: fix memory leak

From: Linus Walleij <hidden>
Date: 2018-03-20 00:58:11

On Mon, Mar 19, 2018 at 7:40 AM, Igor Pylypiv [off-list ref] wrote:
cppcheck report:
[drivers/net/ethernet/cortina/gemini.c:543]: (error) Memory leak: skb_tab

Signed-off-by: Igor Pylypiv <redacted>
Acked-by: Linus Walleij <redacted>

Yours,
Linus Walleij

[PATCH] net: gemini: fix memory leak

From: davem@davemloft.net (David Miller)
Date: 2018-03-20 16:09:35

From: Igor Pylypiv <redacted>
Date: Sun, 18 Mar 2018 23:40:51 -0700
cppcheck report:
[drivers/net/ethernet/cortina/gemini.c:543]: (error) Memory leak: skb_tab

Signed-off-by: Igor Pylypiv <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help