[PATCH] enic: fix boolreturn.cocci warnings

STALE3144d

2 messages, 2 authors, 2018-03-07 · open the first message on its own page

[PATCH] enic: fix boolreturn.cocci warnings

From: kbuild test robot <hidden>
Date: 2018-03-06 18:23:57

From: Fengguang Wu <redacted>

drivers/net/ethernet/cisco/enic/vnic_dev.c:1294:9-10: WARNING: return of 0/1 in function 'vnic_dev_capable_udp_rss' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 48398b6e7065 ("enic: set UDP rss flag")
CC: Govindarajulu Varadarajan <redacted>
Signed-off-by: Fengguang Wu <redacted>
---

 vnic_dev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/ethernet/cisco/enic/vnic_dev.c
+++ b/drivers/net/ethernet/cisco/enic/vnic_dev.c
@@ -1291,7 +1291,7 @@ bool vnic_dev_capable_udp_rss(struct vni
 
 	err = vnic_dev_cmd(vdev, CMD_CAPABILITY, &a0, &a1, wait);
 	if (err || !a0)
-		return 0;
+		return false;
 
 	rss_hash_type = (a1 >> NIC_CFG_RSS_HASH_TYPE_SHIFT) &
 			NIC_CFG_RSS_HASH_TYPE_MASK_FIELD;

Re: [PATCH] enic: fix boolreturn.cocci warnings

From: David Miller <davem@davemloft.net>
Date: 2018-03-07 18:37:30

From: kbuild test robot <redacted>
Date: Wed, 7 Mar 2018 02:23:23 +0800
From: Fengguang Wu <redacted>

drivers/net/ethernet/cisco/enic/vnic_dev.c:1294:9-10: WARNING: return of 0/1 in function 'vnic_dev_capable_udp_rss' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 48398b6e7065 ("enic: set UDP rss flag")
CC: Govindarajulu Varadarajan <redacted>
Signed-off-by: Fengguang Wu <redacted>
Applied to net-next.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help