[PATCH] caif_dev: use true and false for boolean values

Subsystems: networking [general], the rest

STALE3129d

2 messages, 1 author, 2018-03-22 · open the first message on its own page

[PATCH] caif_dev: use true and false for boolean values

From: Gustavo A. R. Silva <hidden>
Date: 2018-03-05 22:05:39

Assign true or false to boolean variables instead of an integer value.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <redacted>
---
 net/caif/caif_dev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c
index e0adcd1..f2848d6 100644
--- a/net/caif/caif_dev.c
+++ b/net/caif/caif_dev.c
@@ -139,7 +139,7 @@ static void caif_flow_cb(struct sk_buff *skb)
 
 	spin_lock_bh(&caifd->flow_lock);
 	send_xoff = caifd->xoff;
-	caifd->xoff = 0;
+	caifd->xoff = false;
 	dtor = caifd->xoff_skb_dtor;
 
 	if (WARN_ON(caifd->xoff_skb != skb))
@@ -213,7 +213,7 @@ static int transmit(struct cflayer *layer, struct cfpkt *pkt)
 	pr_debug("queue has stopped(%d) or is full (%d > %d)\n",
 			netif_queue_stopped(caifd->netdev),
 			qlen, high);
-	caifd->xoff = 1;
+	caifd->xoff = true;
 	caifd->xoff_skb = skb;
 	caifd->xoff_skb_dtor = skb->destructor;
 	skb->destructor = caif_flow_cb;
@@ -400,7 +400,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
 			break;
 		}
 
-		caifd->xoff = 0;
+		caifd->xoff = false;
 		cfcnfg_set_phy_state(cfg, &caifd->layer, true);
 		rcu_read_unlock();
 
@@ -435,7 +435,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
 		if (caifd->xoff_skb_dtor != NULL && caifd->xoff_skb != NULL)
 			caifd->xoff_skb->destructor = caifd->xoff_skb_dtor;
 
-		caifd->xoff = 0;
+		caifd->xoff = false;
 		caifd->xoff_skb_dtor = NULL;
 		caifd->xoff_skb = NULL;
 
-- 
2.7.4

Re: [PATCH] caif_dev: use true and false for boolean values

From: Gustavo A. R. Silva <hidden>
Date: 2018-03-22 19:25:06

Hi all,

I was just wondering about the status of this patch.

Thanks!
--
Gustavo

On 03/05/2018 04:05 PM, Gustavo A. R. Silva wrote:
quoted hunk
Assign true or false to boolean variables instead of an integer value.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <redacted>
---
  net/caif/caif_dev.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c
index e0adcd1..f2848d6 100644
--- a/net/caif/caif_dev.c
+++ b/net/caif/caif_dev.c
@@ -139,7 +139,7 @@ static void caif_flow_cb(struct sk_buff *skb)
  
  	spin_lock_bh(&caifd->flow_lock);
  	send_xoff = caifd->xoff;
-	caifd->xoff = 0;
+	caifd->xoff = false;
  	dtor = caifd->xoff_skb_dtor;
  
  	if (WARN_ON(caifd->xoff_skb != skb))
@@ -213,7 +213,7 @@ static int transmit(struct cflayer *layer, struct cfpkt *pkt)
  	pr_debug("queue has stopped(%d) or is full (%d > %d)\n",
  			netif_queue_stopped(caifd->netdev),
  			qlen, high);
-	caifd->xoff = 1;
+	caifd->xoff = true;
  	caifd->xoff_skb = skb;
  	caifd->xoff_skb_dtor = skb->destructor;
  	skb->destructor = caif_flow_cb;
@@ -400,7 +400,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
  			break;
  		}
  
-		caifd->xoff = 0;
+		caifd->xoff = false;
  		cfcnfg_set_phy_state(cfg, &caifd->layer, true);
  		rcu_read_unlock();
  
@@ -435,7 +435,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what,
  		if (caifd->xoff_skb_dtor != NULL && caifd->xoff_skb != NULL)
  			caifd->xoff_skb->destructor = caifd->xoff_skb_dtor;
  
-		caifd->xoff = 0;
+		caifd->xoff = false;
  		caifd->xoff_skb_dtor = NULL;
  		caifd->xoff_skb = NULL;
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help