[PATCH v2] staging: Replace printk() with appropriate net_*macro_ratelimited()
From: Arushi Singhal <hidden>
Date: 2018-03-04 20:49:11
Replace printk having a log level with the appropriate net_*macro_ratelimited. It's better to use actual device name as a prefix in error messages. Indentation is also changed, to fix the checkpatch issue. Signed-off-by: Arushi Singhal <redacted> --- changes in v2 *In previous version printk was changed to pr_*macro(), which is used in kernel instead of calling printk() directly. And for drivers, dev_*macro() or net_*macro_ratelimited() should be used for calling printk() directly. drivers/staging/ipx/af_ipx.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/ipx/af_ipx.c b/drivers/staging/ipx/af_ipx.c
index d21a9d1..9a96962 100644
--- a/drivers/staging/ipx/af_ipx.c
+++ b/drivers/staging/ipx/af_ipx.c@@ -744,13 +744,13 @@ static void ipxitf_discover_netnum(struct ipx_interface *intrfc, intrfc->if_netnum = cb->ipx_source_net; ipxitf_add_local_route(intrfc); } else { - printk(KERN_WARNING "IPX: Network number collision " - "%lx\n %s %s and %s %s\n", - (unsigned long) ntohl(cb->ipx_source_net), - ipx_device_name(i), - ipx_frame_name(i->if_dlink_type), - ipx_device_name(intrfc), - ipx_frame_name(intrfc->if_dlink_type)); + net_warn_ratelimited("IPX: Network number collision " + "%lx\n %s %s and %s %s\n", + (unsigned long) ntohl(cb->ipx_source_net), + ipx_device_name(i), + ipx_frame_name(i->if_dlink_type), + ipx_device_name(intrfc), + ipx_frame_name(intrfc->if_dlink_type)); ipxitf_put(i); } }
--
2.7.4