Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

3 messages, 1 author, 2018-03-10 · open the first message on its own page

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2018-03-10 03:10:19

On Fri, 09 Mar 2018 21:34:45 -0500
Steven Rostedt [off-list ref] wrote:
 2 files changed, 1050 insertions(+), 1273 deletions(-)
BTW, it's a bit bigger impact than 223 deletions. As I added a lot of
comments to explain the logic better. Removing comments and white space
from the modifications we have:

 649 insertions(+), 1035 deletions(-)

That's 386 lines of code removed.

-- Steve

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2018-03-10 03:15:23

I don't know what the hell happened, but claws mail just inserted a
ton of people into the Cc (I didn't add you). I noticed it just after I
hit send. The added Cc looks like it came from the email right after the
email I was replying to "Subject: Re: [PATCH v3] kernel.h: Skip
single-eval logic on literals in min()/max()".

Sorry for the spam.

-- Steve


On Fri, 9 Mar 2018 22:10:19 -0500
Steven Rostedt [off-list ref] wrote:
On Fri, 09 Mar 2018 21:34:45 -0500
Steven Rostedt [off-list ref] wrote:
quoted
 2 files changed, 1050 insertions(+), 1273 deletions(-)  
BTW, it's a bit bigger impact than 223 deletions. As I added a lot of
comments to explain the logic better. Removing comments and white space
from the modifications we have:

 649 insertions(+), 1035 deletions(-)

That's 386 lines of code removed.

-- Steve
'

Re: [PATCH 3/3] tracing: Rewrite filter logic to be simpler and faster

From: Steven Rostedt <rostedt@goodmis.org>
Date: 2018-03-10 03:22:38

On Fri, 9 Mar 2018 22:15:23 -0500
Steven Rostedt [off-list ref] wrote:
Sorry for the spam.
A little more spam ;-)

I know what happened, as I'm able to recreate it. For those that use
claws-mail, be careful.

I clicked on the email I wanted to reply to. Then I must have hit the
down arrow key, as it moved the selected email to the next email. I hit
"Reply All", and it showed the email I clicked on (as well as the
subject), but the Cc list belonged to the email that was selected by the
down arrow key.

That's a nasty subtle bug. I think I'll go report this to the claws
folks.

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help