[PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

Subsystems: kernel selftest framework, the rest

STALE3140d

6 messages, 2 authors, 2018-03-12 · open the first message on its own page

[PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

From: Roman Mashak <hidden>
Date: 2018-03-09 22:16:18

Add test cases to exercise code paths responsible for adding or deleting
batch of TC actions.

Signed-off-by: Roman Mashak <redacted>
---
 .../tc-testing/tc-tests/actions/gact.json          | 73 +++++++++++++++++++++-
 1 file changed, 72 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/tc-testing/tc-tests/actions/gact.json b/tools/testing/selftests/tc-testing/tc-tests/actions/gact.json
index e2187b6e0b7a..ae96d0350d7e 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/actions/gact.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/actions/gact.json
@@ -465,5 +465,76 @@
         "teardown": [
             "$TC actions flush action gact"
         ]
+    },
+    {
+        "id": "1021",
+        "name": "Add batch of 32 gact pass actions",
+        "category": [
+            "actions",
+            "gact"
+        ],
+        "setup": [
+            [
+                "$TC actions flush action gact",
+                0,
+                1,
+                255
+            ]
+        ],
+        "cmdUnderTest": "for i in `seq 1 32`; do cmd=\"action pass index $i \"; args=\"$args$cmd\"; done && $TC actions add $args",
+        "expExitCode": "0",
+        "verifyCmd": "$TC actions list action gact",
+        "matchPattern": "^[ \t]+index [0-9]+ ref",
+        "matchCount": "32",
+        "teardown": [
+            "$TC actions flush action gact"
+        ]
+    },
+    {
+        "id": "da7a",
+        "name": "Add batch of 32 gact continue actions with cookie",
+        "category": [
+            "actions",
+            "gact"
+        ],
+        "setup": [
+            [
+                "$TC actions flush action gact",
+                0,
+                1,
+                255
+            ]
+        ],
+        "cmdUnderTest": "for i in `seq 1 32`; do cmd=\"action continue index $i cookie aabbccddeeff112233445566778800a1 \"; args=\"$args$cmd\"; done && $TC actions add $args",
+        "expExitCode": "0",
+        "verifyCmd": "$TC actions list action gact",
+        "matchPattern": "^[ \t]+index [0-9]+ ref",
+        "matchCount": "32",
+        "teardown": [
+            "$TC actions flush action gact"
+        ]
+    },
+    {
+        "id": "8aa3",
+        "name": "Delete batch of 32 gact continue actions",
+        "category": [
+            "actions",
+            "gact"
+        ],
+        "setup": [
+            [
+                "$TC actions flush action gact",
+                0,
+                1,
+                255
+            ],
+            "for i in `seq 1 32`; do cmd=\"action continue index $i \"; args=\"$args$cmd\"; done && $TC actions add $args"
+        ],
+        "cmdUnderTest": "for i in `seq 1 32`; do cmd=\"action gact index $i \"; args=\"$args$cmd\"; done && $TC actions del $args",
+        "expExitCode": "0",
+        "verifyCmd": "$TC actions list action gact",
+        "matchPattern": "^[ \t]+index [0-9]+ ref",
+        "matchCount": "0",
+        "teardown": []
     }
-]
+]
\ No newline at end of file
-- 
2.7.4

Re: [PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

From: David Miller <davem@davemloft.net>
Date: 2018-03-12 14:56:23

From: Roman Mashak <redacted>
Date: Fri,  9 Mar 2018 17:16:12 -0500
Add test cases to exercise code paths responsible for adding or deleting
batch of TC actions.

Signed-off-by: Roman Mashak <redacted>
You submitted this patch twice.

You didn't indicate if this is a new version of the patch or something
like this.

Please resubmit your tc-testing changes, all of them, with this
sorted out.

Re: [PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

From: Roman Mashak <hidden>
Date: 2018-03-12 16:40:00

David Miller [off-list ref] writes:
From: Roman Mashak <redacted>
Date: Fri,  9 Mar 2018 17:16:12 -0500
quoted
Add test cases to exercise code paths responsible for adding or deleting
batch of TC actions.

Signed-off-by: Roman Mashak <redacted>
You submitted this patch twice.

You didn't indicate if this is a new version of the patch or something
like this.
Sorry for that glitch, I've just resent the patch.
Please resubmit your tc-testing changes, all of them, with this
sorted out.

Re: [PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

From: David Miller <davem@davemloft.net>
Date: 2018-03-12 16:42:57

From: Roman Mashak <redacted>
Date: Mon, 12 Mar 2018 12:39:57 -0400
David Miller [off-list ref] writes:
quoted
From: Roman Mashak <redacted>
Date: Fri,  9 Mar 2018 17:16:12 -0500
quoted
Add test cases to exercise code paths responsible for adding or deleting
batch of TC actions.

Signed-off-by: Roman Mashak <redacted>
You submitted this patch twice.

You didn't indicate if this is a new version of the patch or something
like this.
Sorry for that glitch, I've just resent the patch.
quoted
Please resubmit your tc-testing changes, all of them, with this
sorted out.
I said "all of your tc-testing changes" not just this one.

Re: [PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

From: Roman Mashak <hidden>
Date: 2018-03-12 17:15:37

David Miller [off-list ref] writes:
From: Roman Mashak <redacted>
Date: Mon, 12 Mar 2018 12:39:57 -0400
quoted
David Miller [off-list ref] writes:
quoted
From: Roman Mashak <redacted>
Date: Fri,  9 Mar 2018 17:16:12 -0500
quoted
Add test cases to exercise code paths responsible for adding or deleting
batch of TC actions.

Signed-off-by: Roman Mashak <redacted>
You submitted this patch twice.

You didn't indicate if this is a new version of the patch or something
like this.
Sorry for that glitch, I've just resent the patch.
quoted
Please resubmit your tc-testing changes, all of them, with this
sorted out.
I said "all of your tc-testing changes" not just this one.
On March 9th I submitted two tc-testing patches:

 - "add TC vlan action tests"
 - "updated gact tests with batch test cases" (which I resent)

Do you want to have those submitted as series?

Re: [PATCH net-next 1/1] tc-testing: updated gact tests with batch test cases

From: David Miller <davem@davemloft.net>
Date: 2018-03-12 18:47:13

From: Roman Mashak <redacted>
Date: Mon, 12 Mar 2018 13:15:35 -0400
David Miller [off-list ref] writes:
quoted
From: Roman Mashak <redacted>
Date: Mon, 12 Mar 2018 12:39:57 -0400
quoted
David Miller [off-list ref] writes:
quoted
From: Roman Mashak <redacted>
Date: Fri,  9 Mar 2018 17:16:12 -0500
quoted
Add test cases to exercise code paths responsible for adding or deleting
batch of TC actions.

Signed-off-by: Roman Mashak <redacted>
You submitted this patch twice.

You didn't indicate if this is a new version of the patch or something
like this.
Sorry for that glitch, I've just resent the patch.
quoted
Please resubmit your tc-testing changes, all of them, with this
sorted out.
I said "all of your tc-testing changes" not just this one.
On March 9th I submitted two tc-testing patches:

 - "add TC vlan action tests"
 - "updated gact tests with batch test cases" (which I resent)

Do you want to have those submitted as series?
I said resubmit all of them, which means both of these patches.
You only resubmitted one of them.

I really can't figure out how I can be more clear about my
request.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help