pull-request: bpf 2018-03-08

3 messages, 2 authors, 2018-03-08 · open the first message on its own page

pull-request: bpf 2018-03-08

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2018-03-08 01:17:18

Hi David,

The following pull-request contains BPF updates for your *net* tree.

The main changes are:

1) Fix various BPF helpers which adjust the skb and its GSO information
   with regards to SCTP GSO. The latter is a special case where gso_size
   is of value GSO_BY_FRAGS, so mangling that will end up corrupting
   the skb, thus bail out when seeing SCTP GSO packets, from Daniel(s).

2) Fix a compilation error in bpftool where BPF_FS_MAGIC is not defined
   due to too old kernel headers in the system, from Jiri.

3) Increase the number of x64 JIT passes in order to allow larger images
   to converge instead of punting them to interpreter or having them
   rejected when the interpreter is not built into the kernel, from Daniel.

Please consider pulling these changes from:

  git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git

Thanks a lot!

----------------------------------------------------------------

The following changes since commit 4a0c7191c75e94b0aaaa52855bf44d94bfe97403:

  Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf (2018-03-02 20:32:15 -0500)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git 

for you to fetch changes up to 6007b080d2e2adb7af22bf29165f0594ea12b34c:

  bpf, x64: increase number of passes (2018-03-07 14:47:24 -0800)

----------------------------------------------------------------
Daniel Axtens (1):
      bpf: fix bpf_skb_adjust_net/bpf_skb_proto_xlat to deal with gso sctp skbs

Daniel Borkmann (1):
      bpf, x64: increase number of passes

Jiri Benc (1):
      tools: bpftool: fix compilation with older headers

 Documentation/networking/segmentation-offloads.txt | 11 +++-
 arch/x86/net/bpf_jit_comp.c                        |  3 +-
 include/linux/skbuff.h                             | 22 ++++++++
 net/core/filter.c                                  | 60 +++++++++++++++-------
 tools/bpf/bpftool/common.c                         |  4 ++
 5 files changed, 79 insertions(+), 21 deletions(-)

Re: pull-request: bpf 2018-03-08

From: David Miller <davem@davemloft.net>
Date: 2018-03-08 01:31:44

From: Daniel Borkmann <daniel@iogearbox.net>
Date: Thu,  8 Mar 2018 02:17:16 +0100
The following pull-request contains BPF updates for your *net* tree.

The main changes are:

1) Fix various BPF helpers which adjust the skb and its GSO information
   with regards to SCTP GSO. The latter is a special case where gso_size
   is of value GSO_BY_FRAGS, so mangling that will end up corrupting
   the skb, thus bail out when seeing SCTP GSO packets, from Daniel(s).

2) Fix a compilation error in bpftool where BPF_FS_MAGIC is not defined
   due to too old kernel headers in the system, from Jiri.

3) Increase the number of x64 JIT passes in order to allow larger images
   to converge instead of punting them to interpreter or having them
   rejected when the interpreter is not built into the kernel, from Daniel.

Please consider pulling these changes from:

  git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git
Pulled, thanks Daniel.

About that x86 JIT passes thing...

I think since you now have a scheduling point in there, you can be
even more liberal with the limit if necessary.

Re: pull-request: bpf 2018-03-08

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2018-03-08 01:45:00

On 03/08/2018 02:31 AM, David Miller wrote:
From: Daniel Borkmann <daniel@iogearbox.net>
Date: Thu,  8 Mar 2018 02:17:16 +0100
quoted
The following pull-request contains BPF updates for your *net* tree.

The main changes are:

1) Fix various BPF helpers which adjust the skb and its GSO information
   with regards to SCTP GSO. The latter is a special case where gso_size
   is of value GSO_BY_FRAGS, so mangling that will end up corrupting
   the skb, thus bail out when seeing SCTP GSO packets, from Daniel(s).

2) Fix a compilation error in bpftool where BPF_FS_MAGIC is not defined
   due to too old kernel headers in the system, from Jiri.

3) Increase the number of x64 JIT passes in order to allow larger images
   to converge instead of punting them to interpreter or having them
   rejected when the interpreter is not built into the kernel, from Daniel.

Please consider pulling these changes from:

  git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git
Pulled, thanks Daniel.
Thanks!
About that x86 JIT passes thing...

I think since you now have a scheduling point in there, you can be
even more liberal with the limit if necessary.
Agree, if needed we can always adapt it further in future, I think 20
should be good for now.

Thanks,
Daniel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help