Re: dsa with 2 rgmii channels (1st is 2 switches & 2nd is phy)

Hi Michael

                mdio {
                                compatible = "cdns,macb-mdio";
/*                           reg = <0xe000b000 0x1000>; */
/*                           clocks = <&clkc 30>, <&clkc 30>, <&clkc 13>; */
/*                           clock-names = "pclk", "hclk", "tx_clk"; */
                                #address-cells = <1>;
                                #size-cells = <0>;
                                status = "okay";
                                switch0: switch@0 {
                                                compatible = "marvell,mv88e6352";

Please use marvell,mv88e6085. That is what the 6352 is compatible
with.

It would also be good to sort out your mixup between tabs and spaces.

                mdio {
                                compatible = "cdns,macb-mdio";
/*                           reg = <0xe000c000 0x1000>; */
/*                           clocks = <&clkc 31>, <&clkc 31>, <&clkc 14>; */
/*                           clock-names = "pclk", "hclk", "tx_clk"; */
                                #address-cells = <1>;
                                #size-cells = <0>;
                                status = "okay";
                                ethernet_phy: ethernet-phy@0 {
                                                compatible = "marvell,mv88e1510";
                                                device_type = "ethernet-phy";
                                                reg = <0>;
                                };

PHYs don't have compatible strings. It is not needed, you can read the
vendor and model from its registers.

       Andrew

Hello Andrew,

I've noticed that my device model is mv88e6390x and not mv88e6352 as I wrote before.
What is the compatibility value for it?

Regards,
Michael

-----Original Message-----
From: Andrew Lunn [mailto:andrew@lunn.ch] 
Sent: Sunday, March 04, 2018 5:31 PM
To: Alayev Michael
Cc: <redacted>; Dror Alon; Efter Yoram
Subject: Re: dsa with 2 rgmii channels (1st is 2 switches & 2nd is phy)

Hi Michael

                mdio {
                                compatible = "cdns,macb-mdio";
/*                           reg = <0xe000b000 0x1000>; */
/*                           clocks = <&clkc 30>, <&clkc 30>, <&clkc 13>; */
/*                           clock-names = "pclk", "hclk", "tx_clk"; */
                                #address-cells = <1>;
                                #size-cells = <0>;
                                status = "okay";
                                switch0: switch@0 {
                                                compatible = 
"marvell,mv88e6352";

Please use marvell,mv88e6085. That is what the 6352 is compatible with.

It would also be good to sort out your mixup between tabs and spaces.

                mdio {
                                compatible = "cdns,macb-mdio";
/*                           reg = <0xe000c000 0x1000>; */
/*                           clocks = <&clkc 31>, <&clkc 31>, <&clkc 14>; */
/*                           clock-names = "pclk", "hclk", "tx_clk"; */
                                #address-cells = <1>;
                                #size-cells = <0>;
                                status = "okay";
                                ethernet_phy: ethernet-phy@0 {
                                                compatible = "marvell,mv88e1510";
                                                device_type = "ethernet-phy";
                                                reg = <0>;
                                };

PHYs don't have compatible strings. It is not needed, you can read the vendor and model from its registers.

       Andrew

Default Profile
***********************************************************************************************

Please consider the environment before printing this email !
The information contained in this communication is proprietary to Israel Aerospace Industries Ltd. and/or third parties, may contain confidential or privileged information, and is intended only for the use of the intended addressee thereof.
If you are not the intended addressee, please be aware that any use, disclosure, distribution and/or copying of this communication is strictly prohibited. If you receive this communication in error, please notify the sender immediately and delete it from your computer. 
Thank you.

Visit us at:   www.iai.co.il

On Mon, Mar 05, 2018 at 01:12:43PM +0000, Alayev Michael wrote:

Hello Andrew,

I've noticed that my device model is mv88e6390x and not mv88e6352 as I wrote before.
What is the compatibility value for it?

Hi Michael

Documentation/devicetree/binding/net/dsa/marvell.txt says:

Required properties:
- compatible            : Should be one of "marvell,mv88e6085" or
                          "marvell,mv88e6190"

It could be better documented, but in this case, marvell,mv88e6190 is
what you want.

     Andrew

Hi Andrew,

You have advised me to change the compatibility to "marvell,mv88e6190".
The problem is that my linux version is Xilinx 4.4.0 (2016.2) - it contains mv88e6xxx driver files that do not support 6190 (though they do support 6085) and the driver has slightly different file tree.
The closest Xilinx linux version that support this driver is 4.10.

The thing is, I don't want to upgrade my linux version, just patch this driver module.
Is it possible to do it in a simple way (windows like :) )?

Regards,
Michael

-----Original Message-----
From: Andrew Lunn [mailto:andrew@lunn.ch] 
Sent: Monday, March 05, 2018 4:15 PM
To: Alayev Michael
Cc: <redacted>; Dror Alon; Efter Yoram
Subject: Re: dsa with 2 rgmii channels (1st is 2 switches & 2nd is phy)

On Mon, Mar 05, 2018 at 01:12:43PM +0000, Alayev Michael wrote:

Hello Andrew,

I've noticed that my device model is mv88e6390x and not mv88e6352 as I wrote before.
What is the compatibility value for it?

Hi Michael

Documentation/devicetree/binding/net/dsa/marvell.txt says:

Required properties:
- compatible            : Should be one of "marvell,mv88e6085" or
                          "marvell,mv88e6190"

It could be better documented, but in this case, marvell,mv88e6190 is what you want.

     Andrew

Default Profile
***********************************************************************************************

Please consider the environment before printing this email !
The information contained in this communication is proprietary to Israel Aerospace Industries Ltd. and/or third parties, may contain confidential or privileged information, and is intended only for the use of the intended addressee thereof.
If you are not the intended addressee, please be aware that any use, disclosure, distribution and/or copying of this communication is strictly prohibited. If you receive this communication in error, please notify the sender immediately and delete it from your computer. 
Thank you.

Visit us at:   www.iai.co.il

On Fri, Mar 09, 2018 at 08:00:40AM +0000, Alayev Michael wrote:

Hi Andrew,

You have advised me to change the compatibility to "marvell,mv88e6190".
The problem is that my linux version is Xilinx 4.4.0 (2016.2) - it contains mv88e6xxx driver files that do not support 6190 (though they do support 6085) and the driver has slightly different file tree.
The closest Xilinx linux version that support this driver is 4.10.

The thing is, I don't want to upgrade my linux version, just patch this driver module.
Is it possible to do it in a simple way (windows like :) )?

To support a 6190, you need something much newer than 4.4. It does not
support the 6390 family. It took a lot of patches to make the 6390
work. 4.10 will mostly work, but the Ethernet PHYs might be broken, or
at least not use the Marvell PHY driver. And VLAN probably don't
work. But you don't want to use 4.10, it is a dead kernel, no security
fixes.

Ideally you want 4.14, which is a long term stable kernel. 

	Andrew