From: Jakub Kicinski <hidden> Date: 2018-03-24 02:42:35
From: Dirk van der Merwe <redacted>
The NSP default buffer is a piece of NFP memory where additional
command data can be placed. Its format has been copied from
host buffer, but the PCIe selection bits do not make sense in
this case. If those get masked out from a NFP address - writes
to random place in the chip memory may be issued and crash the
device.
This has never been an issue because the buffer used to be
allocated in memory with less-than-38-bit-long address but that
is about to change.
Signed-off-by: Dirk van der Merwe <redacted>
Signed-off-by: Jakub Kicinski <redacted>
---
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
From: Jakub Kicinski <hidden> Date: 2018-03-25 14:28:09
On Fri, 23 Mar 2018 19:42:22 -0700, Jakub Kicinski wrote:
quoted hunk
From: Dirk van der Merwe <redacted>
The NSP default buffer is a piece of NFP memory where additional
command data can be placed. Its format has been copied from
host buffer, but the PCIe selection bits do not make sense in
this case. If those get masked out from a NFP address - writes
to random place in the chip memory may be issued and crash the
device.
This has never been an issue because the buffer used to be
allocated in memory with less-than-38-bit-long address but that
is about to change.
Signed-off-by: Dirk van der Merwe <redacted>
Signed-off-by: Jakub Kicinski <redacted>
---
drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nsp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)