[PATCH net-next] net/sched: remove tcf_idr_cleanup()

Subsystems: networking [general], tc subsystem, the rest

STALE3135d

2 messages, 2 authors, 2018-03-24 · open the first message on its own page

[PATCH net-next] net/sched: remove tcf_idr_cleanup()

From: Davide Caratti <hidden>
Date: 2018-03-23 18:09:51

tcf_idr_cleanup() is no more used, so remove it.

Suggested-by: Cong Wang <redacted>
Signed-off-by: Davide Caratti <redacted>
---
 include/net/act_api.h | 1 -
 net/sched/act_api.c   | 8 --------
 2 files changed, 9 deletions(-)
diff --git a/include/net/act_api.h b/include/net/act_api.h
index e0a9c2003b24..9e59ebfded62 100644
--- a/include/net/act_api.h
+++ b/include/net/act_api.h
@@ -149,7 +149,6 @@ bool tcf_idr_check(struct tc_action_net *tn, u32 index, struct tc_action **a,
 int tcf_idr_create(struct tc_action_net *tn, u32 index, struct nlattr *est,
 		   struct tc_action **a, const struct tc_action_ops *ops,
 		   int bind, bool cpustats);
-void tcf_idr_cleanup(struct tc_action *a, struct nlattr *est);
 void tcf_idr_insert(struct tc_action_net *tn, struct tc_action *a);
 
 int __tcf_idr_release(struct tc_action *a, bool bind, bool strict);
diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index 57cf37145282..7bd1b964f021 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -296,14 +296,6 @@ bool tcf_idr_check(struct tc_action_net *tn, u32 index, struct tc_action **a,
 }
 EXPORT_SYMBOL(tcf_idr_check);
 
-void tcf_idr_cleanup(struct tc_action *a, struct nlattr *est)
-{
-	if (est)
-		gen_kill_estimator(&a->tcfa_rate_est);
-	free_tcf(a);
-}
-EXPORT_SYMBOL(tcf_idr_cleanup);
-
 int tcf_idr_create(struct tc_action_net *tn, u32 index, struct nlattr *est,
 		   struct tc_action **a, const struct tc_action_ops *ops,
 		   int bind, bool cpustats)
-- 
2.14.3

Re: [PATCH net-next] net/sched: remove tcf_idr_cleanup()

From: David Miller <davem@davemloft.net>
Date: 2018-03-24 01:52:31

From: Davide Caratti <redacted>
Date: Fri, 23 Mar 2018 19:09:39 +0100
tcf_idr_cleanup() is no more used, so remove it.

Suggested-by: Cong Wang <redacted>
Signed-off-by: Davide Caratti <redacted>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help