# Re: \[RFC PATCH\] inet: frags: lowpan\_rhash\_params can be static

- From: Eric Dumazet \<hidden\>
- Date: 2018-03-31 13:46:42 
- List: netdev
- Page: https://ratatoskr.run/netdev/2018/03/11087337
- Thread: https://ratatoskr.run/netdev/2018/03/11087278/t.md

```text


On 03/31/2018 12:47 AM, kbuild test robot wrote:
> 
> Fixes: b051dbce5e50 ("inet: frags: use rhashtables for reassembly units")
> Signed-off-by: Fengguang Wu <redacted>
> ---
>  reassembly.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ieee802154/6lowpan/reassembly.c b/net/ieee802154/6lowpan/reassembly.c
> index dd743c2..0fa0121 100644
> --- a/net/ieee802154/6lowpan/reassembly.c
> +++ b/net/ieee802154/6lowpan/reassembly.c
> @@ -597,7 +597,7 @@ static int lowpan_obj_cmpfn(struct rhashtable_compare_arg *arg, const void *ptr)
>  	return !!memcmp(&fq->key, key, sizeof(*key));
>  }
>  
> -const struct rhashtable_params lowpan_rhash_params = {
> +static const struct rhashtable_params lowpan_rhash_params = {
>  	.head_offset		= offsetof(struct inet_frag_queue, node),
>  	.hashfn			= lowpan_key_hashfn,
>  	.obj_hashfn		= lowpan_obj_hashfn,
> 

Thanks for the report/patch. I will squash this in the V4 submission.
```