[PATCH net 1/1] qede: Do not drop rx-checksum invalidated packets.

Subsystems: networking drivers, qlogic ql4xxx ethernet driver, the rest

STALE3123d

2 messages, 2 authors, 2018-03-29 · open the first message on its own page

[PATCH net 1/1] qede: Do not drop rx-checksum invalidated packets.

From: Manish Chopra <hidden>
Date: 2018-03-28 10:36:00

Today, driver drops received packets which are indicated as
invalid checksum by the device. Instead of dropping such packets,
pass them to the stack with CHECKSUM_NONE indication in skb.

Signed-off-by: Ariel Elior <redacted>
Signed-off-by: Manish Chopra <redacted>
---
 drivers/net/ethernet/qlogic/qede/qede_fp.c |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c b/drivers/net/ethernet/qlogic/qede/qede_fp.c
index 2e921ca..1494130 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_fp.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c
@@ -1247,16 +1247,10 @@ static int qede_rx_process_cqe(struct qede_dev *edev,
 
 	csum_flag = qede_check_csum(parse_flag);
 	if (unlikely(csum_flag == QEDE_CSUM_ERROR)) {
-		if (qede_pkt_is_ip_fragmented(fp_cqe, parse_flag)) {
+		if (qede_pkt_is_ip_fragmented(fp_cqe, parse_flag))
 			rxq->rx_ip_frags++;
-		} else {
-			DP_NOTICE(edev,
-				  "CQE has error, flags = %x, dropping incoming packet\n",
-				  parse_flag);
+		else
 			rxq->rx_hw_errors++;
-			qede_recycle_rx_bd_ring(rxq, fp_cqe->bd_num);
-			return 0;
-		}
 	}
 
 	/* Basic validation passed; Need to prepare an SKB. This would also
-- 
1.7.1

Re: [PATCH net 1/1] qede: Do not drop rx-checksum invalidated packets.

From: David Miller <davem@davemloft.net>
Date: 2018-03-29 18:32:38

From: Manish Chopra <redacted>
Date: Wed, 28 Mar 2018 03:35:52 -0700
Today, driver drops received packets which are indicated as
invalid checksum by the device. Instead of dropping such packets,
pass them to the stack with CHECKSUM_NONE indication in skb.

Signed-off-by: Ariel Elior <redacted>
Signed-off-by: Manish Chopra <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help