[PATCH][next] xen-netback: make function xenvif_rx_skb static

Subsystems: networking drivers, the rest, xen network backend driver

STALE3116d

3 messages, 3 authors, 2018-02-26 · open the first message on its own page

[PATCH][next] xen-netback: make function xenvif_rx_skb static

From: Colin King <hidden>
Date: 2018-02-23 17:17:03

From: Colin Ian King <redacted>

The function xenvif_rx_skb is local to the source and does not need
to be in global scope, so make it static.

Cleans up sparse warning:
drivers/net/xen-netback/rx.c:422:6: warning: symbol 'xenvif_rx_skb'
was not declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/xen-netback/rx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netback/rx.c b/drivers/net/xen-netback/rx.c
index b1cf7c6f407a..ef5887037b22 100644
--- a/drivers/net/xen-netback/rx.c
+++ b/drivers/net/xen-netback/rx.c
@@ -419,7 +419,7 @@ static void xenvif_rx_extra_slot(struct xenvif_queue *queue,
 	BUG();
 }
 
-void xenvif_rx_skb(struct xenvif_queue *queue)
+static void xenvif_rx_skb(struct xenvif_queue *queue)
 {
 	struct xenvif_pkt_state pkt;
 
-- 
2.15.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH][next] xen-netback: make function xenvif_rx_skb static

From: Wei Liu <hidden>
Date: 2018-02-23 17:42:31

On Fri, Feb 23, 2018 at 05:16:57PM +0000, Colin King wrote:
From: Colin Ian King <redacted>

The function xenvif_rx_skb is local to the source and does not need
to be in global scope, so make it static.

Cleans up sparse warning:
drivers/net/xen-netback/rx.c:422:6: warning: symbol 'xenvif_rx_skb'
was not declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
Acked-by: Wei Liu <redacted>

Thanks

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH][next] xen-netback: make function xenvif_rx_skb static

From: David Miller <davem@davemloft.net>
Date: 2018-02-26 16:37:22

From: Colin King <redacted>
Date: Fri, 23 Feb 2018 17:16:57 +0000
From: Colin Ian King <redacted>

The function xenvif_rx_skb is local to the source and does not need
to be in global scope, so make it static.

Cleans up sparse warning:
drivers/net/xen-netback/rx.c:422:6: warning: symbol 'xenvif_rx_skb'
was not declared. Should it be static?

Signed-off-by: Colin Ian King <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help