Re: [PATCH net] tg3: APE heartbeat changes

On Sat, Feb 17, 2018 at 2:56 AM, David Miller [off-list ref] wrote:

From: Satish Baddipadige <redacted>
Date: Fri, 16 Feb 2018 10:01:29 +0530

quoted

@@ -990,6 +984,18 @@ static void tg3_ape_driver_state_change(struct tg3 *tp, int kind)
      tg3_ape_send_event(tp, event);
 }

+static inline void tg3_send_ape_heartbeat(struct tg3 *tp,

Inline functions are not appropriate in foo.c files, please drop the
inline keyword and let the compiler device.

Thanks David. Will send a v2 patch with inline dropped.

Thanks,
Satish