Re: [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO
From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2018-02-27 14:00:38
On 02/25/2018 04:51 AM, Linus Walleij wrote:
This kills off the platform data support from the bitbanged GPIO-based MDIO driver and moves it over to using GPIO descriptors exclusively. We are certainly not going to merge any more platforms into the kernel using platform data, and nothing is using it at the moment. The only concern would be out-of-tree platforms, and those are not the concern of the kernel community. They need to move to use device tree (or ACPI etc) like everyone else.
Please refrain from making statements like those because there are perfectly valid use cases for never seeing ACPI or Device Tree for a given platform, yes there will be push back, and yes, if DT or ACPI is possible, it should be used but I can guarantee you there are platforms out there that won't be converted to DT (e.g: tons of MIPS-based router, x86 add-on modules etc.). Nack on patches 1 and 3, because I am slowly resuming work on an x86 platform driver that uses the mdio-gpio driver with platform data, and DT is not an option there, and I would rather not have to revert your changes.
This was tested on the bit-banged GPIO MDIO on the D-Link DNS-313 and works fine for me. Linus Walleij (5): net: mdio-gpio: Localize platform data net: mdio-gpio: Allocate state in probe() net: mdio-gpio: Remove non-DT probe path net: mdio-gpio: Merge platform data into state net: mdio-gpio: Move to gpiod API MAINTAINERS | 1 - drivers/net/phy/Kconfig | 2 +- drivers/net/phy/mdio-gpio.c | 151 ++++++++++---------------------- include/linux/platform_data/mdio-gpio.h | 33 ------- 4 files changed, 47 insertions(+), 140 deletions(-) delete mode 100644 include/linux/platform_data/mdio-gpio.h
-- Florian