[net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect

Subsystems: bpf [general] (safe dynamic programs and tools), the rest, xdp (express data path)

3 messages, 3 authors, 2018-02-14 · open the first message on its own page

[net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect

From: Tushar Dave <hidden>
Date: 2018-02-09 19:56:42

Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure.
e.g.
[root@labbpf]# ./xdp_redirect $(</sys/class/net/eth2/ifindex) \
$(</sys/class/net/eth3/ifindex)
failed to create a map: 1 Operation not permitted

The failure is seen when executing xdp_redirect while xdp_monitor
is already runnig.

Signed-off-by: Tushar Dave <redacted>
---
 samples/bpf/xdp_redirect_user.c | 7 +++++++
 1 file changed, 7 insertions(+)
diff --git a/samples/bpf/xdp_redirect_user.c b/samples/bpf/xdp_redirect_user.c
index 4475d83..2490235 100644
--- a/samples/bpf/xdp_redirect_user.c
+++ b/samples/bpf/xdp_redirect_user.c
@@ -20,6 +20,7 @@
 #include <string.h>
 #include <unistd.h>
 #include <libgen.h>
+#include <sys/resource.h>
 
 #include "bpf_load.h"
 #include "bpf_util.h"
@@ -75,6 +76,7 @@ static void usage(const char *prog)
 
 int main(int argc, char **argv)
 {
+	struct rlimit r = {RLIM_INFINITY, RLIM_INFINITY};
 	const char *optstr = "SN";
 	char filename[256];
 	int ret, opt, key = 0;
@@ -98,6 +100,11 @@ int main(int argc, char **argv)
 		return 1;
 	}
 
+	if (setrlimit(RLIMIT_MEMLOCK, &r)) {
+		perror("setrlimit(RLIMIT_MEMLOCK)");
+		return 1;
+	}
+
 	ifindex_in = strtoul(argv[optind], NULL, 0);
 	ifindex_out = strtoul(argv[optind + 1], NULL, 0);
 	printf("input: %d output: %d\n", ifindex_in, ifindex_out);
-- 
1.9.1

Re: [net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect

From: Alexei Starovoitov <hidden>
Date: 2018-02-14 01:44:05

On Fri, Feb 09, 2018 at 11:56:12AM -0800, Tushar Dave wrote:
Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure.
e.g.
[root@labbpf]# ./xdp_redirect $(</sys/class/net/eth2/ifindex) \
quoted
$(</sys/class/net/eth3/ifindex)
failed to create a map: 1 Operation not permitted

The failure is seen when executing xdp_redirect while xdp_monitor
is already runnig.

Signed-off-by: Tushar Dave <redacted>
Applied to bpf-next, thanks Tushar.

Re: [net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect

From: John Fastabend <john.fastabend@gmail.com>
Date: 2018-02-14 02:56:19

On 02/09/2018 11:56 AM, Tushar Dave wrote:
Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure.
e.g.
[root@labbpf]# ./xdp_redirect $(</sys/class/net/eth2/ifindex) \
quoted
$(</sys/class/net/eth3/ifindex)
failed to create a map: 1 Operation not permitted

The failure is seen when executing xdp_redirect while xdp_monitor
is already runnig.

Signed-off-by: Tushar Dave <redacted>
---
Looks good to me.

Acked-by: John Fastabend <john.fastabend@gmail.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help