[PATCH] qed: code indent should use tabs where possible

Subsystems: networking drivers, qlogic ql4xxx ethernet driver, the rest

STALE3150d

3 messages, 3 authors, 2018-01-25 · open the first message on its own page

[PATCH] qed: code indent should use tabs where possible

From: Rohit Visavalia <hidden>
Date: 2018-01-25 10:26:34

Issue found by checkpatch.

Signed-off-by: Rohit Visavalia <redacted>
---
 drivers/net/ethernet/qlogic/qed/qed_rdma.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
index b7abb8205d3a..ae399c48d4a3 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
@@ -360,13 +360,13 @@ static void qed_rdma_resc_free(struct qed_hwfn *p_hwfn)
 
 static void qed_rdma_free_tid(void *rdma_cxt, u32 itid)
 {
-        struct qed_hwfn *p_hwfn = (struct qed_hwfn *)rdma_cxt;
+	struct qed_hwfn *p_hwfn = (struct qed_hwfn *)rdma_cxt;
 
-        DP_VERBOSE(p_hwfn, QED_MSG_RDMA, "itid = %08x\n", itid);
+	DP_VERBOSE(p_hwfn, QED_MSG_RDMA, "itid = %08x\n", itid);
 
-        spin_lock_bh(&p_hwfn->p_rdma_info->lock);
-        qed_bmap_release_id(p_hwfn, &p_hwfn->p_rdma_info->tid_map, itid);
-        spin_unlock_bh(&p_hwfn->p_rdma_info->lock);
+	spin_lock_bh(&p_hwfn->p_rdma_info->lock);
+	qed_bmap_release_id(p_hwfn, &p_hwfn->p_rdma_info->tid_map, itid);
+	spin_unlock_bh(&p_hwfn->p_rdma_info->lock);
 }
 
 static void qed_rdma_free_reserved_lkey(struct qed_hwfn *p_hwfn)
-- 
2.16.1

RE: [PATCH] qed: code indent should use tabs where possible

From: Kalderon, Michal <hidden>
Date: 2018-01-25 10:32:04

quoted hunk
From: Rohit Visavalia [mailto:rohit.visavalia@softnautics.com]
Sent: Thursday, January 25, 2018 12:26 PM
To: Elior, Ariel <redacted>; Dept-Eng Everest Linux L2 <Dept-
EngEverestLinuxL2@cavium.com>
Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Rohit Visavalia
[off-list ref]
Subject: [PATCH] qed: code indent should use tabs where possible

Issue found by checkpatch.

Signed-off-by: Rohit Visavalia <redacted>
---
 drivers/net/ethernet/qlogic/qed/qed_rdma.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
index b7abb8205d3a..ae399c48d4a3 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_rdma.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_rdma.c
@@ -360,13 +360,13 @@ static void qed_rdma_resc_free(struct qed_hwfn
*p_hwfn)

 static void qed_rdma_free_tid(void *rdma_cxt, u32 itid)  {
-        struct qed_hwfn *p_hwfn = (struct qed_hwfn *)rdma_cxt;
+	struct qed_hwfn *p_hwfn = (struct qed_hwfn *)rdma_cxt;

-        DP_VERBOSE(p_hwfn, QED_MSG_RDMA, "itid = %08x\n", itid);
+	DP_VERBOSE(p_hwfn, QED_MSG_RDMA, "itid = %08x\n", itid);

-        spin_lock_bh(&p_hwfn->p_rdma_info->lock);
-        qed_bmap_release_id(p_hwfn, &p_hwfn->p_rdma_info->tid_map,
itid);
-        spin_unlock_bh(&p_hwfn->p_rdma_info->lock);
+	spin_lock_bh(&p_hwfn->p_rdma_info->lock);
+	qed_bmap_release_id(p_hwfn, &p_hwfn->p_rdma_info->tid_map,
itid);
+	spin_unlock_bh(&p_hwfn->p_rdma_info->lock);
 }

 static void qed_rdma_free_reserved_lkey(struct qed_hwfn *p_hwfn)
--
2.16.1
Thanks and apologies,

Acked-by: Michal Kalderon <redacted>

Re: [PATCH] qed: code indent should use tabs where possible

From: David Miller <davem@davemloft.net>
Date: 2018-01-25 21:37:09

From: Rohit Visavalia <redacted>
Date: Thu, 25 Jan 2018 15:56:14 +0530
Issue found by checkpatch.

Signed-off-by: Rohit Visavalia <redacted>
Applied to net-next.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help