[PATCH] [net-next] net: socionext: include linux/io.h to fix build

Subsystems: networking drivers, socionext (sni) netsec network driver, the rest

STALE3164d

3 messages, 3 authors, 2018-01-11 · open the first message on its own page

[PATCH] [net-next] net: socionext: include linux/io.h to fix build

From: Arnd Bergmann <arnd@arndb.de>
Date: 2018-01-11 10:36:58

I ran into a randconfig build failure:

drivers/net/ethernet/socionext/netsec.c: In function 'netsec_probe':
drivers/net/ethernet/socionext/netsec.c:1583:17: error: implicit declaration of function 'devm_ioremap'; did you mean 'ioremap'? [-Werror=implicit-function-declaration]

Including linux/io.h directly fixes this.

Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/socionext/netsec.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
index a8edcf387bba..af47147dd656 100644
--- a/drivers/net/ethernet/socionext/netsec.c
+++ b/drivers/net/ethernet/socionext/netsec.c
@@ -8,6 +8,7 @@
 #include <linux/of_mdio.h>
 #include <linux/etherdevice.h>
 #include <linux/interrupt.h>
+#include <linux/io.h>
 
 #include <net/tcp.h>
 #include <net/ip6_checksum.h>
-- 
2.9.0

Re: [PATCH] [net-next] net: socionext: include linux/io.h to fix build

From: Ard Biesheuvel <hidden>
Date: 2018-01-11 10:38:21

On 11 January 2018 at 10:36, Arnd Bergmann [off-list ref] wrote:
I ran into a randconfig build failure:

drivers/net/ethernet/socionext/netsec.c: In function 'netsec_probe':
drivers/net/ethernet/socionext/netsec.c:1583:17: error: implicit declaration of function 'devm_ioremap'; did you mean 'ioremap'? [-Werror=implicit-function-declaration]

Including linux/io.h directly fixes this.

Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks for fixing this. This is the same issue spotted by kbuild test robot.

Acked-by: Ard Biesheuvel <redacted>
quoted hunk
---
 drivers/net/ethernet/socionext/netsec.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
index a8edcf387bba..af47147dd656 100644
--- a/drivers/net/ethernet/socionext/netsec.c
+++ b/drivers/net/ethernet/socionext/netsec.c
@@ -8,6 +8,7 @@
 #include <linux/of_mdio.h>
 #include <linux/etherdevice.h>
 #include <linux/interrupt.h>
+#include <linux/io.h>

 #include <net/tcp.h>
 #include <net/ip6_checksum.h>
--
2.9.0

Re: [PATCH] [net-next] net: socionext: include linux/io.h to fix build

From: David Miller <davem@davemloft.net>
Date: 2018-01-11 18:54:40

From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 11 Jan 2018 11:36:24 +0100
I ran into a randconfig build failure:

drivers/net/ethernet/socionext/netsec.c: In function 'netsec_probe':
drivers/net/ethernet/socionext/netsec.c:1583:17: error: implicit declaration of function 'devm_ioremap'; did you mean 'ioremap'? [-Werror=implicit-function-declaration]

Including linux/io.h directly fixes this.

Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thank you.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help